sam_oneal/dial-reference
1
0
Fork 0
mirror of https://github.com/Netflix/dial-reference.git synced 2026-06-08 02:49:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in dial_data.

Browse Source
This commit is contained in:
Chintan Parikh
2017-10-02 15:25:03 -07:00
parent 50f7a5085d
commit 4b8f7637b1
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/dial_data.c
View File

@@ -41,7 +41,7 @@ void set_dial_data_dir(const char *data_dir) {
/** /**
* Returns the path where data is stored for the given app. * Returns the path where data is stored for the given app.
*/ */
static char* getAppPath(char app_name[]) { static char* getAppPath(char *app_name) {
size_t name_size = strlen(app_name) + sizeof(dial_data_dir) + 1; size_t name_size = strlen(app_name) + sizeof(dial_data_dir) + 1;
char* filename = (char*) malloc(name_size); char* filename = (char*) malloc(name_size);
filename[0] = 0; filename[0] = 0;
@@ -57,6 +57,7 @@ void store_dial_data(char app_name[], DIALData *data) {
printf("Cannot open DIAL data output file: %s\n", filename); printf("Cannot open DIAL data output file: %s\n", filename);
exit(1); exit(1);
} }
free(filename);
for (DIALData *first = data; first != NULL; first = first->next) { for (DIALData *first = data; first != NULL; first = first->next) {
fprintf(f, "%s %s\n", first->key, first->value); fprintf(f, "%s %s\n", first->key, first->value);
} }
@@ -66,6 +67,7 @@ void store_dial_data(char app_name[], DIALData *data) {
DIALData *retrieve_dial_data(char *app_name) { DIALData *retrieve_dial_data(char *app_name) {
char* filename = getAppPath(app_name); char* filename = getAppPath(app_name);
FILE *f = fopen(filename, "r"); FILE *f = fopen(filename, "r");
free(filename);
if (f == NULL) { if (f == NULL) {
return NULL; // no dial data found, that's fine return NULL; // no dial data found, that's fine
} }