From e9020894028097b8022826eb1c1cbea1c3966fe5 Mon Sep 17 00:00:00 2001 From: Chintan Parikh Date: Mon, 2 Oct 2017 16:06:32 -0700 Subject: [PATCH] Replace unsafe strcpy with strncpy. Valgrind is happy now. --- server/dial_data.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/dial_data.c b/server/dial_data.c index b25659a..1ef8192 100644 --- a/server/dial_data.c +++ b/server/dial_data.c @@ -76,10 +76,10 @@ DIALData *retrieve_dial_data(char *app_name) { char value[256]; while (fscanf(f, "%255s %255s\n", key, value) != EOF) { DIALData *newNode = (DIALData *) malloc(sizeof(DIALData)); - newNode->key = (char *) malloc(strlen(key)); - strcpy(newNode->key, key); - newNode->value = (char *) malloc(strlen(value)); - strcpy(newNode->value, value); + newNode->key = (char *) calloc(1, strlen(key)); + strncpy(newNode->key, key, strlen(key)); + newNode->value = (char *) calloc(1, strlen(value)); + strncpy(newNode->value, value, strlen(value)); newNode->next = result; result = newNode; }