sam_oneal/fx_cast
1
0
Fork 0
mirror of https://github.com/hensm/fx_cast.git synced 2026-06-11 01:59:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix duplicate subtitle media control menus

Browse Source
This commit is contained in:
hensm
2022-09-06 08:41:03 +01:00
parent 989c798f69
commit 13ca18ad9a
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ext/src/ui/popup/Receiver.svelte
View File

@@ -185,7 +185,7 @@
: "" : ""
}); });
updateMediaMenus(); updateMediaMenus(info.menuIds as (string | number)[]);
browser.menus.refresh(); browser.menus.refresh();
} }
@@ -279,13 +279,23 @@
} }
/** Updates media menu items from media status. */ /** Updates media menu items from media status. */
function updateMediaMenus() { function updateMediaMenus(shownMenuIds: (number | string)[]) {
// Clear caption submenu for re-build // Clear caption submenu for re-build
if (captionSubmenus.size) { if (captionSubmenus.size) {
for (const menuId of captionSubmenus.keys()) { for (const menuId of captionSubmenus.keys()) {
browser.menus.remove(menuId); browser.menus.remove(menuId);
} }
captionSubmenus.clear(); captionSubmenus.clear();
} else {
// Clear caption submenus from previous instances
for (const menuId of shownMenuIds as string[] | number[]) {
if (
typeof menuId === "string" &&
menuId.startsWith("subtitle-")
) {
browser.menus.remove(menuId);
}
}
} }
// Hide all media menu items if no media status // Hide all media menu items if no media status
@@ -359,6 +369,7 @@
for (const track of textTracks) { for (const track of textTracks) {
const menuId = browser.menus.create({ const menuId = browser.menus.create({
id: `subtitle-${track.trackId}`,
title: track.name ?? track.trackId.toString(), title: track.name ?? track.trackId.toString(),
parentId: menuIds.POPUP_MEDIA_CC, parentId: menuIds.POPUP_MEDIA_CC,
type: "radio", type: "radio",