From 14d3b2c8338ea39a9cec7b125b389ac69a08220a Mon Sep 17 00:00:00 2001 From: hensm Date: Fri, 16 Aug 2019 21:09:35 +0100 Subject: [PATCH] Fix unused parameters --- app/src/bridge/Media.ts | 12 ++- app/src/bridge/index.ts | 6 +- app/src/transforms.ts | 6 +- common/tsconfig.json | 1 + .../NativeReceiverSelector.ts | 15 ++-- .../receiverSelector/ReceiverSelector.ts | 2 +- .../ReceiverSelectorManager.ts | 4 +- ext/src/lib/nativeMessaging.ts | 2 +- ext/src/lib/userAgents.ts | 4 +- ext/src/senders/mediaCast.ts | 4 +- ext/src/senders/mirroringCast.ts | 2 +- ext/src/shim/cast/classes/Session.ts | 14 ++-- ext/src/shim/cast/index.ts | 16 ++-- ext/src/shim/cast/media/classes/Media.ts | 74 +++++++++---------- ext/src/shim/framework/GoogleCastLauncher.ts | 2 +- ext/src/shim/framework/classes/CastContext.ts | 4 +- ext/src/shim/framework/classes/CastSession.ts | 22 +++--- .../classes/RemotePlayerController.ts | 2 +- ext/src/shim/framework/index.ts | 2 +- ext/src/shim/index.ts | 2 +- ext/src/ui/options/EditableList.tsx | 2 +- 21 files changed, 95 insertions(+), 103 deletions(-) diff --git a/app/src/bridge/Media.ts b/app/src/bridge/Media.ts index 8246269..2bf7d6a 100644 --- a/app/src/bridge/Media.ts +++ b/app/src/bridge/Media.ts @@ -11,8 +11,8 @@ import { Message const MEDIA_NAMESPACE = "urn:x-cast:com.google.cast.media"; export interface UpdateMessageData { - _volumeLevel: number; - _volumeMuted: boolean; + _volumeLevel?: number; + _volumeMuted?: boolean; _lastCurrentTime: number; currentTime: number; customData?: any; @@ -28,9 +28,7 @@ export default class Media { private channel: Channel; constructor ( - sessionId: number - , mediaSessionId: number - , private referenceId: string + private referenceId: string , private session: Session , private sendMessageCallback: SendMessageCallback) { @@ -43,7 +41,7 @@ export default class Media { const status = data.status[0]; - const messageData = { + const messageData: UpdateMessageData = { _lastCurrentTime: Date.now() / 1000 , currentTime: status.currentTime @@ -51,7 +49,7 @@ export default class Media { , playbackRate: status.playbackRate , playerState: status.playerState , repeatMode: status.repeatMode - } as UpdateMessageData; + }; if (status.volume) { messageData._volumeLevel = status.volume.level; diff --git a/app/src/bridge/index.ts b/app/src/bridge/index.ts index a2cd2a0..fdee836 100755 --- a/app/src/bridge/index.ts +++ b/app/src/bridge/index.ts @@ -100,9 +100,7 @@ async function handleMessage (message: Message) { if (parentSession) { // Create Media existingMedia.set(mediaId, new Media( - message.data.sessionId - , message.data.mediaSessionId - , mediaId + mediaId , parentSession , sendMessage)); } @@ -271,7 +269,7 @@ function handleMediaServerMessage (message: Message) { mediaServer.on("close", () => { sendMessage("mediaCast:/mediaServer/stopped"); }); - mediaServer.on("error", (a) => { + mediaServer.on("error", () => { sendMessage("mediaCast:/mediaServer/error"); }); diff --git a/app/src/transforms.ts b/app/src/transforms.ts index 0fde151..7f9ab22 100755 --- a/app/src/transforms.ts +++ b/app/src/transforms.ts @@ -20,7 +20,7 @@ export class ResponseTransform extends Transform { public _transform ( chunk: Message - , encoding: string + , _encoding: string // tslint:disable-next-line:ban-types , callback: Function) { @@ -53,7 +53,7 @@ export class DecodeTransform extends Transform { public _transform ( chunk: any - , encoding: string + , _encoding: string // tslint:disable-next-line:ban-types , callback: Function) { @@ -113,7 +113,7 @@ export class EncodeTransform extends Transform { public _transform ( chunk: any - , encoding: string + , _encoding: string // tslint:disable-next-line:ban-types , callback: Function) { diff --git a/common/tsconfig.json b/common/tsconfig.json index 8f8078e..d6d4d00 100644 --- a/common/tsconfig.json +++ b/common/tsconfig.json @@ -4,6 +4,7 @@ , "module": "commonjs" , "noImplicitAny": true , "noUnusedLocals": true + , "noUnusedParameters": true , "removeComments": true , "resolveJsonModule": true , "target": "es6" diff --git a/ext/src/background/receiverSelector/NativeReceiverSelector.ts b/ext/src/background/receiverSelector/NativeReceiverSelector.ts index 90a17e2..b667e1a 100644 --- a/ext/src/background/receiverSelector/NativeReceiverSelector.ts +++ b/ext/src/background/receiverSelector/NativeReceiverSelector.ts @@ -21,11 +21,6 @@ interface NativeReceiverSelectorSelectedMessage extends Message { data: ReceiverSelection; } -interface NativeReceiverSelectorCloseMessage extends Message { - subject: "main:/receiverSelector/error"; - data: string; -} - interface NativeReceiverSelectorErrorMessage extends Message { subject: "main:/receiverSelector/error"; data: string; @@ -65,8 +60,7 @@ export default class NativeReceiverSelector break; } case "main:/receiverSelector/close": { - this.onBridgePortMessageClose( - message as NativeReceiverSelectorCloseMessage); + this.onBridgePortMessageClose(); break; } } @@ -140,12 +134,13 @@ export default class NativeReceiverSelector private async onBridgePortMessageError ( message: NativeReceiverSelectorErrorMessage) { + console.error("fx_cast (Debug): Native receiver selector error" + , message.data); + this.dispatchEvent(new CustomEvent("error")); } - private async onBridgePortMessageClose ( - message: NativeReceiverSelectorCloseMessage) { - + private async onBridgePortMessageClose () { if (!this.wasReceiverSelected) { this.dispatchEvent(new CustomEvent("cancelled")); } diff --git a/ext/src/background/receiverSelector/ReceiverSelector.ts b/ext/src/background/receiverSelector/ReceiverSelector.ts index 856b353..edd8d90 100644 --- a/ext/src/background/receiverSelector/ReceiverSelector.ts +++ b/ext/src/background/receiverSelector/ReceiverSelector.ts @@ -20,7 +20,7 @@ export interface ReceiverSelection { export interface ReceiverSelectorEvents { "selected": ReceiverSelection; - "error": void; + "error": string; "cancelled": void; } diff --git a/ext/src/background/receiverSelector/ReceiverSelectorManager.ts b/ext/src/background/receiverSelector/ReceiverSelectorManager.ts index 77cb951..ebe7030 100644 --- a/ext/src/background/receiverSelector/ReceiverSelectorManager.ts +++ b/ext/src/background/receiverSelector/ReceiverSelectorManager.ts @@ -72,12 +72,12 @@ async function getSelection ( resolve(ev.detail); }); - sharedSelector.addEventListener("cancelled", ev => { + sharedSelector.addEventListener("cancelled", () => { console.info("fx_cast (Debug): Cancelled receiver selection"); resolve(null); }); - sharedSelector.addEventListener("error", ev => { + sharedSelector.addEventListener("error", () => { console.error("fx_cast (Debug): Failed to select receiver"); reject(); }); diff --git a/ext/src/lib/nativeMessaging.ts b/ext/src/lib/nativeMessaging.ts index c9a5efa..9a6a482 100644 --- a/ext/src/lib/nativeMessaging.ts +++ b/ext/src/lib/nativeMessaging.ts @@ -100,7 +100,7 @@ function connectNative (application: string) { socket = new WebSocket(WEBSOCKET_DAEMON_URL); - socket.addEventListener("open", ev => { + socket.addEventListener("open", () => { // Send all messages in queue while (messageQueue.length) { const message = messageQueue.pop(); diff --git a/ext/src/lib/userAgents.ts b/ext/src/lib/userAgents.ts index 53b4ba2..47acf2c 100644 --- a/ext/src/lib/userAgents.ts +++ b/ext/src/lib/userAgents.ts @@ -11,7 +11,7 @@ const UA_CHROME_LEGACY = "AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.288 const UA_SAFARI = "AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Safari/605.1.15"; -function getPlatformComponent (platform: string) { +function getPlatformComponent (platform: string): string { switch (platform) { case "mac": return PLATFORM_MAC; break; case "win": return PLATFORM_WIN; break; @@ -31,6 +31,6 @@ export function getChromeUserAgent ( return `${UA_PREFIX} (${platformComponent}) ${browserComponent}`; } -export function getSafariUserAgent (platform: string): string { +export function getSafariUserAgent (): string { return `${UA_PREFIX} (${PLATFORM_MAC}) ${UA_SAFARI}`; } diff --git a/ext/src/senders/mediaCast.ts b/ext/src/senders/mediaCast.ts index 186af52..88e9f5e 100644 --- a/ext/src/senders/mediaCast.ts +++ b/ext/src/senders/mediaCast.ts @@ -17,7 +17,7 @@ function getLocalAddress () { resolve(ev.candidate.candidate.split(" ")[4]); } }); - pc.addEventListener("error", ev => { + pc.addEventListener("error", () => { reject(); }); }); @@ -109,7 +109,7 @@ function getSession (opts: InitOptions): Promise { } function getMedia (opts: InitOptions): Promise { - return new Promise(async (resolve, reject) => { + return new Promise(async resolve => { let mediaUrlObject = new URL(opts.mediaUrl); const mediaTitle = mediaUrlObject.pathname; diff --git a/ext/src/senders/mirroringCast.ts b/ext/src/senders/mirroringCast.ts index baa015d..cac8f5e 100644 --- a/ext/src/senders/mirroringCast.ts +++ b/ext/src/senders/mirroringCast.ts @@ -50,7 +50,7 @@ async function onRequestSessionSuccess (newSession: cast.Session) { session = newSession; session.addMessageListener(FX_CAST_RECEIVER_APP_NAMESPACE - , async (namespace, message) => { + , async (_namespace, message) => { const { subject, data } = JSON.parse(message); diff --git a/ext/src/shim/cast/classes/Session.ts b/ext/src/shim/cast/classes/Session.ts index 9c2c0b4..b1aa7c5 100755 --- a/ext/src/shim/cast/classes/Session.ts +++ b/ext/src/shim/cast/classes/Session.ts @@ -249,7 +249,7 @@ export default class Session { } - public addMediaListener (listener: MediaListener) { + public addMediaListener (_mediaListener: MediaListener) { console.info("STUB :: Session#addMediaListener"); } @@ -313,7 +313,7 @@ export default class Session { this.addMessageListener( "urn:x-cast:com.google.cast.media" - , (namespace, data) => { + , (_namespace, data) => { if (hasResponded) { return; @@ -346,14 +346,14 @@ export default class Session { } public queueLoad ( - queueLoadRequest: QueueLoadRequest - , successCallback: LoadSuccessCallback - , errorCallback: ErrorCallback): void { + _queueLoadRequest: QueueLoadRequest + , _successCallback: LoadSuccessCallback + , _errorCallback: ErrorCallback): void { console.info("STUB :: Session#queueLoad"); } - public removeMediaListener (listener: MediaListener): void { + public removeMediaListener (_mediaListener: MediaListener): void { console.info("STUB :: Session#removeMediaListener"); } @@ -365,7 +365,7 @@ export default class Session { } public removeUpdateListener ( - namespace: string + _namespace: string , listener: UpdateListener): void { _updateListeners.get(this).delete(listener); diff --git a/ext/src/shim/cast/index.ts b/ext/src/shim/cast/index.ts index 49ba2ef..1e84978 100755 --- a/ext/src/shim/cast/index.ts +++ b/ext/src/shim/cast/index.ts @@ -117,7 +117,7 @@ export function logMessage (message: string): void { console.log("CAST MSG:", message); } -export function precache (data: string): void { +export function precache (_data: string): void { console.info("STUB :: cast.precache"); } @@ -130,7 +130,7 @@ export function removeReceiverActionListener ( export function requestSession ( successCallback?: RequestSessionSuccessCallback , errorCallback?: ErrorCallback - , sessionRequest: SessionRequest = apiConfig.sessionRequest): void { + , _sessionRequest: SessionRequest = apiConfig.sessionRequest): void { console.info("fx_cast (Debug): cast.requestSession"); @@ -247,23 +247,23 @@ export function _requestSession ( } } -export function requestSessionById (sessionId: string): void { +export function requestSessionById (_sessionId: string): void { console.info("STUB :: cast.requestSessionById"); } export function setCustomReceivers ( - receivers: Receiver_[] - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _receivers: Receiver_[] + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: cast.setCustomReceivers"); } -export function setPageContext (win: Window): void { +export function setPageContext (_win: Window): void { console.info("STUB :: cast.setPageContext"); } -export function setReceiverDisplayStatus (sessionId: string): void { +export function setReceiverDisplayStatus (_sessionId: string): void { console.info("STUB :: cast.setReceiverDisplayStatus"); } diff --git a/ext/src/shim/cast/media/classes/Media.ts b/ext/src/shim/cast/media/classes/Media.ts index 071f883..5b0fb5b 100644 --- a/ext/src/shim/cast/media/classes/Media.ts +++ b/ext/src/shim/cast/media/classes/Media.ts @@ -141,9 +141,9 @@ export default class Media { } public editTracksInfo ( - editTracksInfoRequest: EditTracksInfoRequest - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _editTracksInfoRequest: EditTracksInfoRequest + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#editTracksInfo"); } @@ -158,7 +158,7 @@ export default class Media { } public getStatus ( - getStatusRequest?: GetStatusRequest + _getStatusRequest?: GetStatusRequest , successCallback?: SuccessCallback , errorCallback?: ErrorCallback): void { @@ -167,7 +167,7 @@ export default class Media { } public pause ( - pauseRequest: PauseRequest + _pauseRequest: PauseRequest , successCallback?: SuccessCallback , errorCallback?: ErrorCallback): void { @@ -176,7 +176,7 @@ export default class Media { } public play ( - playRequest?: PlayRequest + _playRequest?: PlayRequest , successCallback?: SuccessCallback , errorCallback?: ErrorCallback): void { @@ -185,71 +185,71 @@ export default class Media { } public queueAppendItem ( - item: QueueItem - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _item: QueueItem + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueAppendItem"); } public queueInsertItems ( - queueInsertItemsRequest: QueueInsertItemsRequest - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _queueInsertItemsRequest: QueueInsertItemsRequest + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueInsertItems"); } public queueJumpToItem ( - itemId: number - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _itemId: number + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueJumpToItem"); } public queueMoveItemToNewIndex ( - itemId: number - , newIndex: number - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _itemId: number + , _newIndex: number + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueMoveItemToNewIndex"); } public queueNext ( - successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueNext"); } public queuePrev ( - successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queuePrev"); } public queueRemoveItem ( - itemId: number - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _itemId: number + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueRemoveItem"); } public queueReorderItems ( - queueReorderItemsRequest: QueueReorderItemsRequest - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _queueReorderItemsRequest: QueueReorderItemsRequest + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueReorderItems"); } public queueSetRepeatMode ( - repeatMode: string - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _repeatMode: string + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueSetRepeatMode"); } public queueUpdateItems ( - queueUpdateItemsRequest: QueueUpdateItemsRequest - , successCallback?: SuccessCallback - , errorCallback?: ErrorCallback): void { + _queueUpdateItemsRequest: QueueUpdateItemsRequest + , _successCallback?: SuccessCallback + , _errorCallback?: ErrorCallback): void { console.info("STUB :: Media#queueUpdateItems"); } @@ -280,7 +280,7 @@ export default class Media { } public stop ( - stopRequest: StopRequest + _stopRequest: StopRequest , successCallback?: SuccessCallback , errorCallback?: ErrorCallback): void { @@ -289,7 +289,7 @@ export default class Media { }, successCallback, errorCallback); } - public supportsCommand (command: string): boolean { + public supportsCommand (_command: string): boolean { console.info("STUB :: Media#supportsCommand"); return true; } diff --git a/ext/src/shim/framework/GoogleCastLauncher.ts b/ext/src/shim/framework/GoogleCastLauncher.ts index 23a845d..502abb2 100644 --- a/ext/src/shim/framework/GoogleCastLauncher.ts +++ b/ext/src/shim/framework/GoogleCastLauncher.ts @@ -71,7 +71,7 @@ export default class GoogleCastLauncher extends HTMLElement { shadow.append(icon, style); - this.addEventListener("click", ev => { + this.addEventListener("click", () => { console.info(" onClick"); }); } diff --git a/ext/src/shim/framework/classes/CastContext.ts b/ext/src/shim/framework/classes/CastContext.ts index 8abf7a5..ee2bd80 100644 --- a/ext/src/shim/framework/classes/CastContext.ts +++ b/ext/src/shim/framework/classes/CastContext.ts @@ -5,7 +5,7 @@ import CastSession from "./CastSession"; export default class CastContext extends EventTarget { - public endCurrentSession (stopCasting: boolean): void { + public endCurrentSession (_stopCasting: boolean): void { console.info("STUB :: CastContext#endCurrentSession"); } @@ -29,7 +29,7 @@ export default class CastContext extends EventTarget { console.info("STUB :: CastContext#requestSession"); } - public setOptions (options: CastOptions): void { + public setOptions (_options: CastOptions): void { console.info("STUB :: CastContext#setOptions"); } } diff --git a/ext/src/shim/framework/classes/CastSession.ts b/ext/src/shim/framework/classes/CastSession.ts index 4a1e1a9..b21262e 100644 --- a/ext/src/shim/framework/classes/CastSession.ts +++ b/ext/src/shim/framework/classes/CastSession.ts @@ -9,19 +9,19 @@ type MessageListener = (namespace: string, message: string) => void; export default class CastSession extends EventTarget { - constructor (sessionObj: cast.Session, state: string) { + constructor (_sessionObj: cast.Session, _state: string) { super(); console.info("STUB :: CastSession#constructor"); } public addMessageListener ( - namespace: string - , listener: MessageListener): void { + _namespace: string + , _listener: MessageListener): void { console.info("STUB :: CastSession#addMessageListener"); } - public endSession (stopCasting: boolean): void { + public endSession (_stopCasting: boolean): void { console.info("STUB :: CastSession#endSession"); } @@ -76,32 +76,32 @@ export default class CastSession extends EventTarget { } // @ts-ignore - public loadMedia (loadRequest: cast.media.LoadRequest): Promise { + public loadMedia (_loadRequest: cast.media.LoadRequest): Promise { console.info("STUB :: CastSession#loadMedia"); } public removeMessageListener ( - namespace: string - , listener: MessageListener): void { + _namespace: string + , _listener: MessageListener): void { console.info("STUB :: CastSession#removeMessageListener"); } public sendMessage ( - namespace: string + _namespace: string // @ts-ignore - , data: any): Promise { + , _data: any): Promise { console.info("STUB :: CastSession#sendMessage"); } // @ts-ignore - public setMute (isMute: boolean): Promise { + public setMute (_isMute: boolean): Promise { console.info("STUB :: CastSession#setMute"); } // @ts-ignore - public setVolume (volume: number): Promise { + public setVolume (_volume: number): Promise { console.info("STUB :: CastSession#setVolume"); } } diff --git a/ext/src/shim/framework/classes/RemotePlayerController.ts b/ext/src/shim/framework/classes/RemotePlayerController.ts index ee321a4..414ce96 100644 --- a/ext/src/shim/framework/classes/RemotePlayerController.ts +++ b/ext/src/shim/framework/classes/RemotePlayerController.ts @@ -4,7 +4,7 @@ import RemotePlayer from "./RemotePlayer"; export default class RemotePlayerController extends EventTarget { - constructor (player: RemotePlayer) { + constructor (_player: RemotePlayer) { super(); console.info("STUB :: RemotePlayerController#constructor"); } diff --git a/ext/src/shim/framework/index.ts b/ext/src/shim/framework/index.ts index fc13b3f..a94ca83 100644 --- a/ext/src/shim/framework/index.ts +++ b/ext/src/shim/framework/index.ts @@ -54,7 +54,7 @@ export default { , VERSION: "1.0.07" - , setLoggerLevel (level: number) { + , setLoggerLevel (_level: number) { console.info("STUB :: cast.framework.setLoggerLevel"); } }; diff --git a/ext/src/shim/index.ts b/ext/src/shim/index.ts index 01edd94..6923519 100755 --- a/ext/src/shim/index.ts +++ b/ext/src/shim/index.ts @@ -52,7 +52,7 @@ if (document.currentScript) { isFramework = true; const script = loadScript(CAST_FRAMEWORK_SCRIPT_URL); - script.addEventListener("load", ev => { + script.addEventListener("load", () => { callPageReadyFunction(); }); diff --git a/ext/src/ui/options/EditableList.tsx b/ext/src/ui/options/EditableList.tsx index 11b03b6..96edec9 100644 --- a/ext/src/ui/options/EditableList.tsx +++ b/ext/src/ui/options/EditableList.tsx @@ -175,7 +175,7 @@ export default class EditableList extends Component< }); } - private handleNewItemEdit (item: string, newItem: string) { + private handleNewItemEdit (_item: string, newItem: string) { this.setState({ addingNewItem: false }, () => {