Remove storage onChanged listener on unload to fix console spam

ext/src/lib/options.ts

@@ -45,21 +45,31 @@ interface EventMap {
 export default new class extends TypedEventTarget<EventMap> {
     constructor () {
         super();
+        this.onStorageChanged = this.onStorageChanged.bind(this);
+        browser.storage.onChanged.addListener(this.onStorageChanged);
+
+        // Supresses sendRemoveListener closed conduit error
+        window.addEventListener("unload", () => {
+            browser.storage.onChanged.removeListener(this.onStorageChanged);
+        });
+    }
+
+    private onStorageChanged(
+            changes: { [key: string]: browser.storage.StorageChange }
+          , areaName: string) {
+
 
-        browser.storage.onChanged.addListener((changes, areaName) => {
         if (areaName !== "sync") {
             return;
         }
 
-            // Types issue
+        if ("options" in changes) {
-            const _changes = changes as {
+            const { oldValue, newValue } = changes.options;
-                [key: string]: browser.storage.StorageChange
-            };
-
-            if ("options" in _changes) {
-                const { oldValue, newValue } = _changes.options;
             const changedKeys = [];
 
+
+
+
             for (const key of Object.keys(newValue)) {
                 if (oldValue) {
                     // Don't track added keys
@@ -70,9 +80,17 @@ export default new class extends TypedEventTarget<EventMap> {
                     const oldKeyValue = oldValue[key];
                     const newKeyValue = newValue[key];
 
+
+
                     // Equality comparison
                     if (oldKeyValue === newKeyValue) {
                         continue;
+
+
+
+
+
+
                     }
 
                     // Array comparison
@@ -87,13 +105,14 @@ export default new class extends TypedEventTarget<EventMap> {
                 }
 
                 changedKeys.push(key);
+
+
             }
 
             this.dispatchEvent(new CustomEvent("changed", {
                 detail: changedKeys as Array<keyof Options>
             }));
         }
-        });
     }
 
     /**