From 1751cee9064a51b67171c259009ab188240e13b2 Mon Sep 17 00:00:00 2001 From: hensm Date: Sun, 1 Mar 2026 19:15:48 +0000 Subject: [PATCH] Add more info about Windns address resolution --- bridge/src/dns_sd/native/dns_sd_platform_browser_win.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bridge/src/dns_sd/native/dns_sd_platform_browser_win.cc b/bridge/src/dns_sd/native/dns_sd_platform_browser_win.cc index df1135c..d549901 100644 --- a/bridge/src/dns_sd/native/dns_sd_platform_browser_win.cc +++ b/bridge/src/dns_sd/native/dns_sd_platform_browser_win.cc @@ -339,7 +339,9 @@ void WINAPI DnsSdPlatformBrowser::Impl::resolve_callback( } } - // Resolve v4/v6 addresses via getaddrinfo + // The v4Address/v6Address fields of DNS_SERVICE_INSTANCE don't seem to be populated + // reliably, but getaddrinfo seems to work consistently in my testing, so we'll just use + // that approach across all platforms. resolve_addresses(service.host, service.address4, service.address6); if (impl->is_started) {