Improve message names

This commit is contained in:
hensm
2022-08-26 21:21:24 +01:00
parent 90b00c0ce4
commit 5b8a55a2de
8 changed files with 25 additions and 24 deletions

View File

@@ -48,8 +48,8 @@ export default class Discovery {
constructor(opts: DiscoveryOptions) { constructor(opts: DiscoveryOptions) {
/** /**
* When a service is found, gather device info from service object and * When a service is found, gather device info from service
* TXT record, then send a `main:receiverDeviceUp` message. * object and TXT record, then send a `main:deviceUp` message.
*/ */
this.browser.on("serviceUp", service => { this.browser.on("serviceUp", service => {
// Filter invalid results // Filter invalid results
@@ -69,7 +69,7 @@ export default class Discovery {
}); });
/** /**
* When a service is lost, send a `main:receiverDeviceDown` message with * When a service is lost, send a `main:deviceDown` message with
* the service name as the `deviceId`. * the service name as the `deviceId`.
*/ */
this.browser.on("serviceDown", service => { this.browser.on("serviceDown", service => {

View File

@@ -39,7 +39,7 @@ messaging.on("message", (message: Message) => {
discovery = new Discovery({ discovery = new Discovery({
onDeviceFound(device) { onDeviceFound(device) {
messaging.sendMessage({ messaging.sendMessage({
subject: "main:receiverDeviceUp", subject: "main:deviceUp",
data: { data: {
deviceId: device.id, deviceId: device.id,
deviceInfo: device deviceInfo: device
@@ -80,7 +80,7 @@ messaging.on("message", (message: Message) => {
}, },
onDeviceDown(deviceId) { onDeviceDown(deviceId) {
messaging.sendMessage({ messaging.sendMessage({
subject: "main:receiverDeviceDown", subject: "main:deviceDown",
data: { deviceId } data: { deviceId }
}); });

View File

@@ -48,12 +48,12 @@ type MessageDefinitions = {
* Sent to extension from the bridge whenever a receiver device is * Sent to extension from the bridge whenever a receiver device is
* found. * found.
*/ */
"main:receiverDeviceUp": { deviceId: string; deviceInfo: ReceiverDevice }; "main:deviceUp": { deviceId: string; deviceInfo: ReceiverDevice };
/** /**
* Sent to extension from the bridge whenever a previously found * Sent to extension from the bridge whenever a previously found
* receiver device is lost. * receiver device is lost.
*/ */
"main:receiverDeviceDown": { deviceId: string }; "main:deviceDown": { deviceId: string };
/** /**
* Sent to the extension from the bridge whenever a * Sent to the extension from the bridge whenever a

View File

@@ -233,25 +233,25 @@ export default class ReceiverSelector extends TypedEventTarget<ReceiverSelectorE
/** Handles messages from the popup extension page. */ /** Handles messages from the popup extension page. */
private onPopupMessage(message: Message) { private onPopupMessage(message: Message) {
switch (message.subject) { switch (message.subject) {
case "receiverSelector:selected": case "main:receiverSelected":
this.wasReceiverSelected = true; this.wasReceiverSelected = true;
this.dispatchEvent( this.dispatchEvent(
new CustomEvent("selected", { detail: message.data }) new CustomEvent("selected", { detail: message.data })
); );
break; break;
case "receiverSelector:stop": case "main:receiverStopped":
this.dispatchEvent( this.dispatchEvent(
new CustomEvent("stop", { detail: message.data }) new CustomEvent("stop", { detail: message.data })
); );
break; break;
case "receiverSelector:receiverMessage": case "main:sendReceiverMessage":
this.dispatchEvent( this.dispatchEvent(
new CustomEvent("receiverMessage", { detail: message.data }) new CustomEvent("receiverMessage", { detail: message.data })
); );
break; break;
case "receiverSelector:mediaMessage": case "main:sendMediaMessage":
this.dispatchEvent( this.dispatchEvent(
new CustomEvent("mediaMessage", { detail: message.data }) new CustomEvent("mediaMessage", { detail: message.data })
); );

View File

@@ -134,7 +134,7 @@ export default new (class extends TypedEventTarget<EventMap> {
private onBridgeMessage = (message: Message) => { private onBridgeMessage = (message: Message) => {
switch (message.subject) { switch (message.subject) {
case "main:receiverDeviceUp": { case "main:deviceUp": {
const { deviceId, deviceInfo } = message.data; const { deviceId, deviceInfo } = message.data;
this.receiverDevices.set(deviceId, deviceInfo); this.receiverDevices.set(deviceId, deviceInfo);
@@ -147,7 +147,7 @@ export default new (class extends TypedEventTarget<EventMap> {
break; break;
} }
case "main:receiverDeviceDown": { case "main:deviceDown": {
const { deviceId } = message.data; const { deviceId } = message.data;
if (this.receiverDevices.has(deviceId)) { if (this.receiverDevices.has(deviceId)) {

View File

@@ -54,16 +54,17 @@ type ExtMessageDefinitions = {
}; };
"popup:close": undefined; "popup:close": undefined;
"receiverSelector:selected": ReceiverSelection; "main:receiverSelected": ReceiverSelection;
"receiverSelector:stop": { deviceId: string }; "main:receiverStopped": { deviceId: string };
"receiverSelector:receiverMessage": ReceiverSelectorReceiverMessage; "main:sendReceiverMessage": ReceiverSelectorReceiverMessage;
"receiverSelector:mediaMessage": ReceiverSelectorMediaMessage; "main:sendMediaMessage": ReceiverSelectorMediaMessage;
"main:selectReceiver": { "main:selectReceiver": {
sessionRequest: SessionRequest; sessionRequest: SessionRequest;
}; };
"cast:selectReceiver/selected": ReceiverSelection; "cast:selectReceiver/selected": ReceiverSelection;
"cast:selectReceiver/cancelled": undefined; "cast:selectReceiver/cancelled": undefined;
"cast:receiverStoppedAction": { deviceId: string }; "cast:receiverStoppedAction": { deviceId: string };
"main:closeReceiverSelector": undefined; "main:closeReceiverSelector": undefined;
@@ -107,12 +108,12 @@ type AppMessageDefinitions = {
* Sent to extension from the bridge whenever a receiver device is * Sent to extension from the bridge whenever a receiver device is
* found. * found.
*/ */
"main:receiverDeviceUp": { deviceId: string; deviceInfo: ReceiverDevice }; "main:deviceUp": { deviceId: string; deviceInfo: ReceiverDevice };
/** /**
* Sent to extension from the bridge whenever a previously found * Sent to extension from the bridge whenever a previously found
* receiver device is lost. * receiver device is lost.
*/ */
"main:receiverDeviceDown": { deviceId: string }; "main:deviceDown": { deviceId: string };
/** /**
* Sent to the extension from the bridge whenever a * Sent to the extension from the bridge whenever a

View File

@@ -343,7 +343,7 @@
isConnecting = true; isConnecting = true;
port?.postMessage({ port?.postMessage({
subject: "receiverSelector:selected", subject: "main:receiverSelected",
data: { data: {
receiverDevice, receiverDevice,
mediaType mediaType
@@ -353,7 +353,7 @@
function onReceiverStop(receiverDevice: ReceiverDevice) { function onReceiverStop(receiverDevice: ReceiverDevice) {
port?.postMessage({ port?.postMessage({
subject: "receiverSelector:receiverMessage", subject: "main:sendReceiverMessage",
data: { data: {
deviceId: receiverDevice.id, deviceId: receiverDevice.id,
message: { requestId: 0, type: "STOP" } message: { requestId: 0, type: "STOP" }
@@ -361,7 +361,7 @@
}); });
port?.postMessage({ port?.postMessage({
subject: "receiverSelector:stop", subject: "main:receiverStopped",
data: { deviceId: receiverDevice.id } data: { deviceId: receiverDevice.id }
}); });
} }

View File

@@ -49,7 +49,7 @@
}; };
port?.postMessage({ port?.postMessage({
subject: "receiverSelector:receiverMessage", subject: "main:sendReceiverMessage",
data: { deviceId: device.id, message } data: { deviceId: device.id, message }
}); });
} }
@@ -68,7 +68,7 @@
}; };
port?.postMessage({ port?.postMessage({
subject: "receiverSelector:mediaMessage", subject: "main:sendMediaMessage",
data: { deviceId: device.id, message } data: { deviceId: device.id, message }
}); });
} }