From 5e4c8d20f476637abd8eb4e33495062d8023fb74 Mon Sep 17 00:00:00 2001 From: hensm Date: Thu, 30 Jan 2020 23:28:49 +0000 Subject: [PATCH] Allow empty frame ID when opening receiver selector from tools menu --- ext/src/background/background.ts | 3 --- ext/src/lib/loadSender.ts | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/ext/src/background/background.ts b/ext/src/background/background.ts index 8bd6387..83cc2fe 100755 --- a/ext/src/background/background.ts +++ b/ext/src/background/background.ts @@ -163,9 +163,6 @@ async function initMenus () { if (tab?.id === undefined) { throw logger.error("Menu handler tab ID not found."); } - if (info.frameId === undefined) { - throw logger.error("Menu handler frame ID not found."); - } if (!info.pageUrl) { throw logger.error("Menu handler page URL not found."); } diff --git a/ext/src/lib/loadSender.ts b/ext/src/lib/loadSender.ts index 033672b..193297c 100644 --- a/ext/src/lib/loadSender.ts +++ b/ext/src/lib/loadSender.ts @@ -12,7 +12,7 @@ import ShimManager from "../background/ShimManager"; interface LoadSenderOptions { tabId: number; - frameId: number; + frameId?: number; selection: ReceiverSelection; }