sam_oneal/fx_cast
1
0
Fork 0
mirror of https://github.com/hensm/fx_cast.git synced 2026-06-08 08:39:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add disabled hint to receiver selector app option (closes #139)

Browse Source
This commit is contained in:
hensm
2020-09-04 13:41:00 +01:00
parent 2838a99393
commit 6960508ca6
3 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CONTRIBUTING.md
View File

@@ -29,12 +29,14 @@ Missing/outdated strings:
* `optionsMirroringCategoryDescription` * `optionsMirroringCategoryDescription`
* `optionsMirroringEnabled` * `optionsMirroringEnabled`
* `optionsMirroringAppId` * `optionsMirroringAppId`
* `popupMediaTypeAppNotFound`
* `es` * `es`
* `optionsMirroringCategoryName` * `optionsMirroringCategoryName`
* `optionsMirroringCategoryDescription` * `optionsMirroringCategoryDescription`
* `optionsMirroringEnabled` * `optionsMirroringEnabled`
* `optionsMirroringAppId` * `optionsMirroringAppId`
& `popupMediaTypeAppNotFound`
* `nl` * `nl`
* `optionsBridgeBackupEnabled` * `optionsBridgeBackupEnabled`
@@ -45,6 +47,7 @@ Missing/outdated strings:
* `optionsMirroringCategoryDescription` * `optionsMirroringCategoryDescription`
* `optionsMirroringEnabled` * `optionsMirroringEnabled`
* `optionsMirroringAppId` * `optionsMirroringAppId`
* `popupMediaTypeAppNotFound`
### NSIS Installer Localization ### NSIS Installer Localization

4
ext/src/_locales/en/messages.json
View File

@@ -13,6 +13,10 @@
"message": "this site's app" "message": "this site's app"
, "description": "Receiver selector media type <option> text for current site's sender application." , "description": "Receiver selector media type <option> text for current site's sender application."
} }
, "popupMediaTypeAppNotFound": {
"message": "this site's app (not found)"
, "description": "Receiver selector media type <option> text for current site's sender application if none found."
}
, "popupMediaTypeAppMedia": { , "popupMediaTypeAppMedia": {
"message": "this media" "message": "this media"
, "description": "Receiver selector media type <option> text for media casting." , "description": "Receiver selector media type <option> text for media casting."

9
ext/src/ui/popup/index.tsx
View File

@@ -149,6 +149,8 @@ class PopupApp extends Component<{}, PopupAppState> {
const isSelectedMediaTypeAvailable = const isSelectedMediaTypeAvailable =
!!(this.state.availableMediaTypes & this.state.mediaType) !!(this.state.availableMediaTypes & this.state.mediaType)
const isAppMediaTypeAvailable = !!(this.state.availableMediaTypes
& ReceiverSelectorMediaType.App);
return ( return (
<div> <div>
@@ -163,10 +165,11 @@ class PopupApp extends Component<{}, PopupAppState> {
<option value={ ReceiverSelectorMediaType.App } <option value={ ReceiverSelectorMediaType.App }
selected={ isAppMediaTypeSelected } selected={ isAppMediaTypeSelected }
disabled={ !(this.state.availableMediaTypes disabled={ !isAppMediaTypeAvailable }>
& ReceiverSelectorMediaType.App) }>
{ (this.state.requestedAppId && knownApps[this.state.requestedAppId]?.name) { (this.state.requestedAppId && knownApps[this.state.requestedAppId]?.name)
?? _("popupMediaTypeApp") } ?? isAppMediaTypeAvailable
? _("popupMediaTypeApp")
: _("popupMediaTypeAppNotFound") }
</option> </option>
{ this.state.mirroringEnabled && { this.state.mirroringEnabled &&