From 8256c9aaba76e33da021c1e7db0d52bc3f362cd5 Mon Sep 17 00:00:00 2001 From: hensm Date: Mon, 26 Apr 2021 07:33:24 +0100 Subject: [PATCH] Fix error calling menus.update before menus exist --- ext/src/background/menus.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/src/background/menus.ts b/ext/src/background/menus.ts index 0185132..5394973 100644 --- a/ext/src/background/menus.ts +++ b/ext/src/background/menus.ts @@ -348,13 +348,13 @@ options.addEventListener("changed", async ev => { const alteredOpts = ev.detail; const newOpts = await options.getAll(); - if (alteredOpts.includes("mediaEnabled")) { + if (menuIdMediaCast && alteredOpts.includes("mediaEnabled")) { browser.menus.update(menuIdMediaCast, { visible: newOpts.mediaEnabled }); } - if (alteredOpts.includes("localMediaEnabled")) { + if (menuIdMediaCast && alteredOpts.includes("localMediaEnabled")) { browser.menus.update(menuIdMediaCast, { targetUrlPatterns: newOpts.localMediaEnabled ? URL_PATTERNS_ALL