From 967b0deee1bfefc8b4db32ecbc3d75766fc5d595 Mon Sep 17 00:00:00 2001 From: hensm Date: Sat, 4 Jun 2022 03:57:19 +0100 Subject: [PATCH] Simplify whitelist input validity checking --- ext/src/ui/options/Whitelist.svelte | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ext/src/ui/options/Whitelist.svelte b/ext/src/ui/options/Whitelist.svelte index 2fc5fb5..229abe9 100644 --- a/ext/src/ui/options/Whitelist.svelte +++ b/ext/src/ui/options/Whitelist.svelte @@ -12,13 +12,11 @@ export let items: WhitelistItemData[]; let isEditing = false; + let isEditingValid = false; let editingIndex: number; let editingInput: HTMLInputElement; let editingValue: string; - $: isEditingValid = - isEditing && REMOTE_MATCH_PATTERN_REGEX.test(editingValue); - async function beginEditing(index: number) { if (isEditing) return; @@ -33,7 +31,7 @@ editingInput.select(); } function finishEditing() { - if (!isEditing || !editingInput.validity.valid) return; + if (!isEditing || !isEditingValid) return; isEditing = false; items[editingIndex].pattern = editingValue; @@ -50,7 +48,7 @@ : "" ); - isEditingValid = editingInput.checkValidity(); + isEditingValid = editingInput.validity.valid; } function addItem() {