sam_oneal/fx_cast
1
0
Fork 0
mirror of https://github.com/hensm/fx_cast.git synced 2026-06-08 08:39:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update blank metadata values from null to undefined to match Chrome

Browse Source
This commit is contained in:
hensm
2019-07-14 09:46:05 +01:00
parent f2907cdc15
commit a62cb01e97
10 changed files with 84 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ext/src/shim/cast/media/classes/GenericMediaMetadata.ts
View File

@@ -6,11 +6,11 @@ import { MetadataType } from "../enums";
export default class GenericMediaMetadata { export default class GenericMediaMetadata {
public images: Image[] = null; public images: Image[] = undefined;
public metadataType: number = MetadataType.GENERIC; public metadataType: number = MetadataType.GENERIC;
public releaseDate: string = null; public releaseDate: string = undefined;
public releaseYear: number = null; public releaseYear: number = undefined;
public subtitle: string = null; public subtitle: string = undefined;
public title: string = null; public title: string = undefined;
public type: number = MetadataType.GENERIC; public type: number = MetadataType.GENERIC;
} }

12
ext/src/shim/cast/media/classes/MovieMediaMetadata.ts
View File

@@ -6,12 +6,12 @@ import { MetadataType } from "../enums";
export default class MovieMediaMetadata { export default class MovieMediaMetadata {
public images: Image[] = null; public images: Image[] = undefined;
public metadataType: number = MetadataType.MOVIE; public metadataType: number = MetadataType.MOVIE;
public releaseDate: string = null; public releaseDate: string = undefined;
public releaseYear: number = null; public releaseYear: number = undefined;
public studio: string = null; public studio: string = undefined;
public subtitle: string = null; public subtitle: string = undefined;
public title: string = null; public title: string = undefined;
public type: number = MetadataType.MOVIE; public type: number = MetadataType.MOVIE;
} }

24
ext/src/shim/cast/media/classes/MusicTrackMediaMetadata.ts
View File

@@ -6,18 +6,18 @@ import { MetadataType } from "../enums";
export default class MusicTrackMediaMetadata { export default class MusicTrackMediaMetadata {
public albumArtist: string = null; public albumArtist: string = undefined;
public albumName: string = null; public albumName: string = undefined;
public artist: string = null; public artist: string = undefined;
public artistName: string = null; public artistName: string = undefined;
public composer: string = null; public composer: string = undefined;
public discNumber: number = null; public discNumber: number = undefined;
public images: Image[] = null; public images: Image[] = undefined;
public metadataType: number = MetadataType.MUSIC_TRACK; public metadataType: number = MetadataType.MUSIC_TRACK;
public releaseDate: string = null; public releaseDate: string = undefined;
public releaseYear: number = null; public releaseYear: number = undefined;
public songName: string = null; public songName: string = undefined;
public title: string = null; public title: string = undefined;
public trackNumber: number = null; public trackNumber: number = undefined;
public type: number = MetadataType.MUSIC_TRACK; public type: number = MetadataType.MUSIC_TRACK;
} }

18
ext/src/shim/cast/media/classes/PhotoMediaMetadata.ts
View File

@@ -6,15 +6,15 @@ import { MetadataType } from "../enums";
export default class PhotoMediaMetadata { export default class PhotoMediaMetadata {
public artist: string = null; public artist: string = undefined;
public creationDateTime: string = null; public creationDateTime: string = undefined;
public height: number = null; public height: number = undefined;
public images: Image[] = null; public images: Image[] = undefined;
public latitude: number = null; public latitude: number = undefined;
public location: string = null; public location: string = undefined;
public longitude: number = null; public longitude: number = undefined;
public metadataType: number = MetadataType.PHOTO; public metadataType: number = MetadataType.PHOTO;
public title: string = null; public title: string = undefined;
public type: number = MetadataType.PHOTO; public type: number = MetadataType.PHOTO;
public width: number = null; public width: number = undefined;
} }

20
ext/src/shim/cast/media/classes/TvShowMediaMetadata.ts
View File

@@ -6,16 +6,16 @@ import { MetadataType } from "../enums";
export default class TvShowMediaMetadata { export default class TvShowMediaMetadata {
public episode: number = null; public episode: number = undefined;
public episodeNumber: number = null; public episodeNumber: number = undefined;
public episodeTitle: string = null; public episodeTitle: string = undefined;
public images: Image[] = null; public images: Image[] = undefined;
public metadataType: number = MetadataType.TV_SHOW; public metadataType: number = MetadataType.TV_SHOW;
public originalAirdate: string = null; public originalAirdate: string = undefined;
public releaseYear: number = null; public releaseYear: number = undefined;
public season: number = null; public season: number = undefined;
public seasonNumber: number = null; public seasonNumber: number = undefined;
public seriesTitle: string = null; public seriesTitle: string = undefined;
public title: string = null; public title: string = undefined;
public type: number = MetadataType.TV_SHOW; public type: number = MetadataType.TV_SHOW;
} }

10
test/spec/shim/media/GenericMediaMetadata.spec.js
View File

@@ -4,12 +4,12 @@ describe("chrome.cast.media.GenericMediaMetadata", () => {
it("should have all properties", async () => { it("should have all properties", async () => {
const genericMediaMetadata = new chrome.cast.media.GenericMediaMetadata(); const genericMediaMetadata = new chrome.cast.media.GenericMediaMetadata();
expect(genericMediaMetadata.images).toBe(null); expect(genericMediaMetadata.images).toBe(undefined);
expect(genericMediaMetadata.metadataType).toBe(0); expect(genericMediaMetadata.metadataType).toBe(0);
expect(genericMediaMetadata.releaseDate).toBe(null); expect(genericMediaMetadata.releaseDate).toBe(undefined);
expect(genericMediaMetadata.releaseYear).toBe(null); expect(genericMediaMetadata.releaseYear).toBe(undefined);
expect(genericMediaMetadata.subtitle).toBe(null); expect(genericMediaMetadata.subtitle).toBe(undefined);
expect(genericMediaMetadata.title).toBe(null); expect(genericMediaMetadata.title).toBe(undefined);
expect(genericMediaMetadata.type).toBe(0); expect(genericMediaMetadata.type).toBe(0);
}); });
}); });

12
test/spec/shim/media/MovieMediaMetadata.spec.js
View File

@@ -4,13 +4,13 @@ describe("chrome.cast.media.MovieMediaMetadata", () => {
it("should have all properties", async () => { it("should have all properties", async () => {
const movieMediaMetadata = new chrome.cast.media.MovieMediaMetadata(); const movieMediaMetadata = new chrome.cast.media.MovieMediaMetadata();
expect(movieMediaMetadata.images).toBe(null); expect(movieMediaMetadata.images).toBe(undefined);
expect(movieMediaMetadata.metadataType).toBe(1); expect(movieMediaMetadata.metadataType).toBe(1);
expect(movieMediaMetadata.releaseDate).toBe(null); expect(movieMediaMetadata.releaseDate).toBe(undefined);
expect(movieMediaMetadata.releaseYear).toBe(null); expect(movieMediaMetadata.releaseYear).toBe(undefined);
expect(movieMediaMetadata.studio).toBe(null); expect(movieMediaMetadata.studio).toBe(undefined);
expect(movieMediaMetadata.subtitle).toBe(null); expect(movieMediaMetadata.subtitle).toBe(undefined);
expect(movieMediaMetadata.title).toBe(null); expect(movieMediaMetadata.title).toBe(undefined);
expect(movieMediaMetadata.type).toBe(1); expect(movieMediaMetadata.type).toBe(1);
}); });
}); });

24
test/spec/shim/media/MusicTrackMediaMetadata.spec.js
View File

@@ -4,19 +4,19 @@ describe("chrome.cast.media.MusicTrackMediaMetadata", () => {
it("should have all properties", async () => { it("should have all properties", async () => {
const musicTrackMediaMetadata = new chrome.cast.media.MusicTrackMediaMetadata(); const musicTrackMediaMetadata = new chrome.cast.media.MusicTrackMediaMetadata();
expect(musicTrackMediaMetadata.albumArtist).toBe(null); expect(musicTrackMediaMetadata.albumArtist).toBe(undefined);
expect(musicTrackMediaMetadata.albumName).toBe(null); expect(musicTrackMediaMetadata.albumName).toBe(undefined);
expect(musicTrackMediaMetadata.artist).toBe(null); expect(musicTrackMediaMetadata.artist).toBe(undefined);
expect(musicTrackMediaMetadata.artistName).toBe(null); expect(musicTrackMediaMetadata.artistName).toBe(undefined);
expect(musicTrackMediaMetadata.composer).toBe(null); expect(musicTrackMediaMetadata.composer).toBe(undefined);
expect(musicTrackMediaMetadata.discNumber).toBe(null); expect(musicTrackMediaMetadata.discNumber).toBe(undefined);
expect(musicTrackMediaMetadata.images).toBe(null); expect(musicTrackMediaMetadata.images).toBe(undefined);
expect(musicTrackMediaMetadata.metadataType).toBe(3); expect(musicTrackMediaMetadata.metadataType).toBe(3);
expect(musicTrackMediaMetadata.releaseDate).toBe(null); expect(musicTrackMediaMetadata.releaseDate).toBe(undefined);
expect(musicTrackMediaMetadata.releaseYear).toBe(null); expect(musicTrackMediaMetadata.releaseYear).toBe(undefined);
expect(musicTrackMediaMetadata.songName).toBe(null); expect(musicTrackMediaMetadata.songName).toBe(undefined);
expect(musicTrackMediaMetadata.title).toBe(null); expect(musicTrackMediaMetadata.title).toBe(undefined);
expect(musicTrackMediaMetadata.trackNumber).toBe(null); expect(musicTrackMediaMetadata.trackNumber).toBe(undefined);
expect(musicTrackMediaMetadata.type).toBe(3); expect(musicTrackMediaMetadata.type).toBe(3);
}); });
}); });

18
test/spec/shim/media/PhotoMediaMetadata.spec.js
View File

@@ -4,16 +4,16 @@ describe("chrome.cast.media.PhotoMediaMetadata", () => {
it("should have all properties", async () => { it("should have all properties", async () => {
const photoMediaMetadata = new chrome.cast.media.PhotoMediaMetadata(); const photoMediaMetadata = new chrome.cast.media.PhotoMediaMetadata();
expect(photoMediaMetadata.artist).toBe(null); expect(photoMediaMetadata.artist).toBe(undefined);
expect(photoMediaMetadata.creationDateTime).toBe(null); expect(photoMediaMetadata.creationDateTime).toBe(undefined);
expect(photoMediaMetadata.height).toBe(null); expect(photoMediaMetadata.height).toBe(undefined);
expect(photoMediaMetadata.images).toBe(null); expect(photoMediaMetadata.images).toBe(undefined);
expect(photoMediaMetadata.latitude).toBe(null); expect(photoMediaMetadata.latitude).toBe(undefined);
expect(photoMediaMetadata.location).toBe(null); expect(photoMediaMetadata.location).toBe(undefined);
expect(photoMediaMetadata.longitude).toBe(null); expect(photoMediaMetadata.longitude).toBe(undefined);
expect(photoMediaMetadata.metadataType).toBe(4); expect(photoMediaMetadata.metadataType).toBe(4);
expect(photoMediaMetadata.title).toBe(null); expect(photoMediaMetadata.title).toBe(undefined);
expect(photoMediaMetadata.type).toBe(4); expect(photoMediaMetadata.type).toBe(4);
expect(photoMediaMetadata.width).toBe(null); expect(photoMediaMetadata.width).toBe(undefined);
}); });
}); });

20
test/spec/shim/media/TvShowMediaMetadata.spec.js
View File

@@ -4,17 +4,17 @@ describe("chrome.cast.media.TvShowMediaMetadata", () => {
it("should have all properties", async () => { it("should have all properties", async () => {
const tvShowMediaMetadata = new chrome.cast.media.TvShowMediaMetadata(); const tvShowMediaMetadata = new chrome.cast.media.TvShowMediaMetadata();
expect(tvShowMediaMetadata.episode).toBe(null); expect(tvShowMediaMetadata.episode).toBe(undefined);
expect(tvShowMediaMetadata.episodeNumber).toBe(null); expect(tvShowMediaMetadata.episodeNumber).toBe(undefined);
expect(tvShowMediaMetadata.episodeTitle).toBe(null); expect(tvShowMediaMetadata.episodeTitle).toBe(undefined);
expect(tvShowMediaMetadata.images).toBe(null); expect(tvShowMediaMetadata.images).toBe(undefined);
expect(tvShowMediaMetadata.metadataType).toBe(2); expect(tvShowMediaMetadata.metadataType).toBe(2);
expect(tvShowMediaMetadata.originalAirdate).toBe(null); expect(tvShowMediaMetadata.originalAirdate).toBe(undefined);
expect(tvShowMediaMetadata.releaseYear).toBe(null); expect(tvShowMediaMetadata.releaseYear).toBe(undefined);
expect(tvShowMediaMetadata.season).toBe(null); expect(tvShowMediaMetadata.season).toBe(undefined);
expect(tvShowMediaMetadata.seasonNumber).toBe(null); expect(tvShowMediaMetadata.seasonNumber).toBe(undefined);
expect(tvShowMediaMetadata.seriesTitle).toBe(null); expect(tvShowMediaMetadata.seriesTitle).toBe(undefined);
expect(tvShowMediaMetadata.title).toBe(null); expect(tvShowMediaMetadata.title).toBe(undefined);
expect(tvShowMediaMetadata.type).toBe(2); expect(tvShowMediaMetadata.type).toBe(2);
}); });
}); });