From b1fdd1e70ec7f852ab3a461d0be6a734e8cbb408 Mon Sep 17 00:00:00 2001 From: hensm Date: Thu, 23 Jan 2020 17:51:06 +0000 Subject: [PATCH] Clean history after receiver selector popup is opened --- .../background/receiverSelector/PopupReceiverSelector.ts | 9 +++++++-- ext/src/manifest.json | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ext/src/background/receiverSelector/PopupReceiverSelector.ts b/ext/src/background/receiverSelector/PopupReceiverSelector.ts index e14cf39..eb38dd2 100644 --- a/ext/src/background/receiverSelector/PopupReceiverSelector.ts +++ b/ext/src/background/receiverSelector/PopupReceiverSelector.ts @@ -12,6 +12,8 @@ import { getWindowCenteredProps, WindowCenteredProps } from "../../lib/utils"; import { Message, Receiver } from "../../types"; +const POPUP_URL = browser.runtime.getURL("ui/popup/index.html"); + export default class PopupReceiverSelector extends TypedEventTarget implements ReceiverSelector { @@ -46,6 +48,9 @@ export default class PopupReceiverSelector * window script. */ browser.runtime.onConnect.addListener(port => { + // Don't polute history + browser.history.deleteUrl({ url: POPUP_URL }); + if (port.name !== "popup") { return; } @@ -116,8 +121,8 @@ export default class PopupReceiverSelector } const popup = await browser.windows.create({ - url: "ui/popup/index.html" - , type: "popup" + url: POPUP_URL + , type: "detached_panel" , ...centeredProps }); diff --git a/ext/src/manifest.json b/ext/src/manifest.json index 6e2883c..2e6c401 100755 --- a/ext/src/manifest.json +++ b/ext/src/manifest.json @@ -47,7 +47,8 @@ "page": "ui/options/index.html" } , "permissions": [ - "menus" + "history" + , "menus" , "nativeMessaging" , "storage" , "tabs"