From c1b6c6734e22c519ac3fa0d5bd0fb76294f7e2b8 Mon Sep 17 00:00:00 2001 From: hensm Date: Sun, 25 Apr 2021 01:34:23 +0100 Subject: [PATCH] Use private fields instead of underscore prefixes --- .../receiverSelector/NativeReceiverSelector.ts | 13 +++++++------ .../receiverSelector/PopupReceiverSelector.ts | 9 ++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ext/src/background/receiverSelector/NativeReceiverSelector.ts b/ext/src/background/receiverSelector/NativeReceiverSelector.ts index 87fddc7..7c14c59 100644 --- a/ext/src/background/receiverSelector/NativeReceiverSelector.ts +++ b/ext/src/background/receiverSelector/NativeReceiverSelector.ts @@ -21,7 +21,8 @@ const _ = browser.i18n.getMessage; export default class NativeReceiverSelector extends ReceiverSelector { private bridgePort: (Port | null) = null; private wasReceiverSelected: boolean = false; - private _isOpen: boolean = false; + + #isOpen = false; constructor () { super(); @@ -29,7 +30,7 @@ export default class NativeReceiverSelector extends ReceiverSelector { } get isOpen () { - return this._isOpen; + return this.#isOpen; } public async open ( @@ -44,7 +45,7 @@ export default class NativeReceiverSelector extends ReceiverSelector { this.bridgePort.onDisconnect.addListener(() => { this.bridgePort = null; this.wasReceiverSelected = false; - this._isOpen = false; + this.#isOpen = false; }); @@ -82,7 +83,7 @@ export default class NativeReceiverSelector extends ReceiverSelector { }) }); - this._isOpen = true; + this.#isOpen = true; } public update (): void { @@ -96,7 +97,7 @@ export default class NativeReceiverSelector extends ReceiverSelector { }); } - this._isOpen = false; + this.#isOpen = false; } private async onBridgePortMessage (message: Message) { @@ -129,7 +130,7 @@ export default class NativeReceiverSelector extends ReceiverSelector { this.bridgePort = null; this.wasReceiverSelected = false; - this._isOpen = false; + this.#isOpen = false; break; } diff --git a/ext/src/background/receiverSelector/PopupReceiverSelector.ts b/ext/src/background/receiverSelector/PopupReceiverSelector.ts index f08e8df..872f21f 100644 --- a/ext/src/background/receiverSelector/PopupReceiverSelector.ts +++ b/ext/src/background/receiverSelector/PopupReceiverSelector.ts @@ -25,10 +25,9 @@ export default class PopupReceiverSelector extends ReceiverSelector { private availableMediaTypes?: ReceiverSelectorMediaType; private wasReceiverSelected: boolean = false; - - private _isOpen: boolean = false; private requestedAppId?: string; + #isOpen = false; constructor () { super(); @@ -49,7 +48,7 @@ export default class PopupReceiverSelector extends ReceiverSelector { } get isOpen () { - return this._isOpen; + return this.#isOpen; } public async open ( @@ -96,7 +95,7 @@ export default class PopupReceiverSelector extends ReceiverSelector { throw logger.error("Failed to create receiver selector popup."); } - this._isOpen = true; + this.#isOpen = true; this.windowId = popup.id; // Size/position not set correctly on creation (bug?) @@ -130,7 +129,7 @@ export default class PopupReceiverSelector extends ReceiverSelector { await browser.windows.remove(this.windowId); } - this._isOpen = false; + this.#isOpen = false; this.requestedAppId = undefined; if (this.messagePort && !this.messagePortDisconnected) {