From 2987a65183722d697adc96e821837d81ec5e4dee Mon Sep 17 00:00:00 2001
From: Bryce Lampe <bryce@pulumi.com>
Date: Mon, 22 Apr 2024 16:28:45 -0700
Subject: [PATCH] Fix diff behavior for buildOnPreview

---
 provider/internal/image.go      |  2 +-
 provider/internal/image_test.go | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/provider/internal/image.go b/provider/internal/image.go
index 406e543..60f9e3a 100644
--- a/provider/internal/image.go
+++ b/provider/internal/image.go
@@ -889,7 +889,7 @@ func (*Image) Diff(
 	if !reflect.DeepEqual(olds.BuildArgs, news.BuildArgs) {
 		diff["buildArgs"] = update
 	}
-	if olds.BuildOnPreview != news.BuildOnPreview {
+	if !reflect.DeepEqual(olds.BuildOnPreview, news.BuildOnPreview) {
 		diff["buildOnPreview"] = update
 	}
 	if !reflect.DeepEqual(olds.Builder, news.Builder) {
diff --git a/provider/internal/image_test.go b/provider/internal/image_test.go
index 401f93a..e209367 100644
--- a/provider/internal/image_test.go
+++ b/provider/internal/image_test.go
@@ -518,7 +518,7 @@ func TestImageDiff(t *testing.T) {
 			wantChanges: true,
 		},
 		{
-			name: "diff if buildOnPreview changes",
+			name: "diff if buildOnPreview doesn't change",
 			olds: func(*testing.T, ImageState) ImageState { return baseState },
 			news: func(t *testing.T, ia ImageArgs) ImageArgs {
 				val := true
@@ -527,6 +527,16 @@ func TestImageDiff(t *testing.T) {
 			},
 			wantChanges: true,
 		},
+		{
+			name: "diff if buildOnPreview changes",
+			olds: func(*testing.T, ImageState) ImageState { return baseState },
+			news: func(t *testing.T, ia ImageArgs) ImageArgs {
+				val := false
+				ia.BuildOnPreview = &val
+				return ia
+			},
+			wantChanges: true,
+		},
 		{
 			name: "diff if ssh changes",
 			olds: func(*testing.T, ImageState) ImageState { return baseState },