Remove URL and Token arguments from CacheFromGitHubActions. (#626)
Fixes #75 Arguments URL and Token have been removed but `$ACTIONS_CACHE_URL` and `$ACTIONS_RUNTIME_TOKEN` env variables could be injected if desired. --------- Co-authored-by: Bryce Lampe <bryce@pulumi.com>
This commit is contained in:
@@ -17,6 +17,7 @@ package internal
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"strings"
|
||||
|
||||
controllerapi "github.com/docker/buildx/controller/pb"
|
||||
@@ -148,33 +149,20 @@ func (c CacheWithOCI) String() string {
|
||||
|
||||
// CacheFromGitHubActions pulls cache manifests from the GitHub actions cache.
|
||||
type CacheFromGitHubActions struct {
|
||||
URL string `pulumi:"url,optional"`
|
||||
Token string `pulumi:"token,optional" provider:"secret"`
|
||||
Scope string `pulumi:"scope,optional"`
|
||||
}
|
||||
|
||||
// Annotate sets docstrings on CacheFromGitHubActions.
|
||||
func (c *CacheFromGitHubActions) Annotate(a infer.Annotator) {
|
||||
a.SetDefault(&c.URL, "", "ACTIONS_CACHE_URL")
|
||||
a.SetDefault(&c.Token, "", "ACTIONS_RUNTIME_TOKEN")
|
||||
a.Describe(&c, dedent(`
|
||||
Recommended for use with GitHub Actions workflows.
|
||||
|
||||
An action like "crazy-max/ghaction-github-runtime" is recommended to expose
|
||||
appropriate credentials to your GitHub workflow.
|
||||
`))
|
||||
|
||||
a.SetDefault(&c.Scope, "buildkit")
|
||||
|
||||
a.Describe(&c.URL, dedent(`
|
||||
The cache server URL to use for artifacts.
|
||||
|
||||
Defaults to "$ACTIONS_CACHE_URL", although a separate action like
|
||||
"crazy-max/ghaction-github-runtime" is recommended to expose this
|
||||
environment variable to your jobs.
|
||||
`))
|
||||
a.Describe(&c.Token, dedent(`
|
||||
The GitHub Actions token to use. This is not a personal access tokens
|
||||
and is typically generated automatically as part of each job.
|
||||
|
||||
Defaults to "$ACTIONS_RUNTIME_TOKEN", although a separate action like
|
||||
"crazy-max/ghaction-github-runtime" is recommended to expose this
|
||||
environment variable to your jobs.
|
||||
|
||||
`))
|
||||
a.Describe(&c.Scope, dedent(`
|
||||
The scope to use for cache keys. Defaults to "buildkit".
|
||||
|
||||
@@ -191,11 +179,12 @@ func (c *CacheFromGitHubActions) String() string {
|
||||
if c.Scope != "" {
|
||||
parts = append(parts, "scope="+c.Scope)
|
||||
}
|
||||
if c.Token != "" {
|
||||
parts = append(parts, "token="+c.Token)
|
||||
// Preserving backwards compatibility with the old behaviour.
|
||||
if token := os.Getenv("ACTIONS_RUNTIME_TOKEN"); token != "" {
|
||||
parts = append(parts, "token="+token)
|
||||
}
|
||||
if c.URL != "" {
|
||||
parts = append(parts, "url="+c.URL)
|
||||
if url := os.Getenv("ACTIONS_CACHE_URL"); url != "" {
|
||||
parts = append(parts, "url="+url)
|
||||
}
|
||||
return strings.Join(parts, ",")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user