Fix GitHub action URL (#80)
Our docs and default value for the GitHub action cache URL were referring to the [wrong](https://github.com/tonistiigi/go-actions-cache/blob/master/api.md) environment variable. I was under the impression that the underlying library ends up checking for the correct variable later so this would be only cosmetic, but a user [confirmed](https://github.com/pulumi/pulumi-docker-build/issues/77#issuecomment-2135621983) this does appear to break things. I brought over an old test I had written while this was still in the pulumi-docker repo, but unfortunately it doesn't currently test GHA due to ci-mgmt limitations https://github.com/pulumi/pulumi-docker-build/issues/82. Fixes https://github.com/pulumi/pulumi-docker-build/issues/77.
This commit is contained in:
8
sdk/nodejs/types/input.ts
generated
8
sdk/nodejs/types/input.ts
generated
@@ -124,7 +124,7 @@ export interface CacheFromGitHubActionsArgs {
|
||||
/**
|
||||
* The cache server URL to use for artifacts.
|
||||
*
|
||||
* Defaults to `$ACTIONS_RUNTIME_URL`, although a separate action like
|
||||
* Defaults to `$ACTIONS_CACHE_URL`, although a separate action like
|
||||
* `crazy-max/ghaction-github-runtime` is recommended to expose this
|
||||
* environment variable to your jobs.
|
||||
*/
|
||||
@@ -138,7 +138,7 @@ export function cacheFromGitHubActionsArgsProvideDefaults(val: CacheFromGitHubAc
|
||||
...val,
|
||||
scope: (val.scope) ?? (utilities.getEnv("buildkit") || ""),
|
||||
token: (val.token) ?? (utilities.getEnv("ACTIONS_RUNTIME_TOKEN") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_RUNTIME_URL") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_CACHE_URL") || ""),
|
||||
};
|
||||
}
|
||||
|
||||
@@ -331,7 +331,7 @@ export interface CacheToGitHubActionsArgs {
|
||||
/**
|
||||
* The cache server URL to use for artifacts.
|
||||
*
|
||||
* Defaults to `$ACTIONS_RUNTIME_URL`, although a separate action like
|
||||
* Defaults to `$ACTIONS_CACHE_URL`, although a separate action like
|
||||
* `crazy-max/ghaction-github-runtime` is recommended to expose this
|
||||
* environment variable to your jobs.
|
||||
*/
|
||||
@@ -347,7 +347,7 @@ export function cacheToGitHubActionsArgsProvideDefaults(val: CacheToGitHubAction
|
||||
mode: (val.mode) ?? "min",
|
||||
scope: (val.scope) ?? (utilities.getEnv("buildkit") || ""),
|
||||
token: (val.token) ?? (utilities.getEnv("ACTIONS_RUNTIME_TOKEN") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_RUNTIME_URL") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_CACHE_URL") || ""),
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
8
sdk/nodejs/types/output.ts
generated
8
sdk/nodejs/types/output.ts
generated
@@ -124,7 +124,7 @@ export interface CacheFromGitHubActions {
|
||||
/**
|
||||
* The cache server URL to use for artifacts.
|
||||
*
|
||||
* Defaults to `$ACTIONS_RUNTIME_URL`, although a separate action like
|
||||
* Defaults to `$ACTIONS_CACHE_URL`, although a separate action like
|
||||
* `crazy-max/ghaction-github-runtime` is recommended to expose this
|
||||
* environment variable to your jobs.
|
||||
*/
|
||||
@@ -138,7 +138,7 @@ export function cacheFromGitHubActionsProvideDefaults(val: CacheFromGitHubAction
|
||||
...val,
|
||||
scope: (val.scope) ?? (utilities.getEnv("buildkit") || ""),
|
||||
token: (val.token) ?? (utilities.getEnv("ACTIONS_RUNTIME_TOKEN") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_RUNTIME_URL") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_CACHE_URL") || ""),
|
||||
};
|
||||
}
|
||||
|
||||
@@ -331,7 +331,7 @@ export interface CacheToGitHubActions {
|
||||
/**
|
||||
* The cache server URL to use for artifacts.
|
||||
*
|
||||
* Defaults to `$ACTIONS_RUNTIME_URL`, although a separate action like
|
||||
* Defaults to `$ACTIONS_CACHE_URL`, although a separate action like
|
||||
* `crazy-max/ghaction-github-runtime` is recommended to expose this
|
||||
* environment variable to your jobs.
|
||||
*/
|
||||
@@ -347,7 +347,7 @@ export function cacheToGitHubActionsProvideDefaults(val: CacheToGitHubActions):
|
||||
mode: (val.mode) ?? "min",
|
||||
scope: (val.scope) ?? (utilities.getEnv("buildkit") || ""),
|
||||
token: (val.token) ?? (utilities.getEnv("ACTIONS_RUNTIME_TOKEN") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_RUNTIME_URL") || ""),
|
||||
url: (val.url) ?? (utilities.getEnv("ACTIONS_CACHE_URL") || ""),
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user