Merge pull request 'Verbs agree with the head of the noun phrase, not the closest noun' (#98) from hippietrail/exercises:grammar into main

Reviewed-on: https://codeberg.org/ziglings/exercises/pulls/98

.devcontainer/devcontainer.json

@@ -0,0 +1,31 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/debian
+{
+	"name": "Ziglings",
+	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+	"image": "mcr.microsoft.com/devcontainers/base:bullseye",
+	"features": {
+		"ghcr.io/devcontainers-contrib/features/zig:1": {
+			"version": "master"
+		}
+	},
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"ziglang.vscode-zig"
+			]
+		}
+	}
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Configure tool-specific properties.
+	// "customizations": {},
+
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "root"
+}

.gitignore

@@ -1,5 +1,8 @@
-/zig-cache/
+/.zig-cache/
 /zig-out/
 /answers/
 /patches/healed/
 /output/
+
+# Leave this in here for older zig versions
+/zig-cache/

.woodpecker/eowyn.yaml

@@ -1,6 +1,7 @@
 steps:
   - name: eowyn
-    image: ziglings/ziglang
+    image: ziglings/ziglang:latest
+    pull: true
     commands:
       - sh ./patches/eowyn.sh
     when:

README.md

@@ -46,7 +46,7 @@ Verify the installation and build number of `zig` like so:
 
 ```
 $ zig version
-0.12.0-dev.xxxx+xxxxxxxxx
+0.13.0-dev.xxxx+xxxxxxxxx
 ```
 
 Clone this repository with Git:
@@ -74,8 +74,8 @@ the appropriate tag.
 The Zig language is under very active development. In order to be
 current, Ziglings tracks **development** builds of the Zig
 compiler rather than versioned **release** builds. The last
-stable release was `0.11.0`, but Ziglings needs a dev build with
+stable release was `0.12.0`, but Ziglings needs a dev build with
-pre-release version "0.12.0" and a build number at least as high
+pre-release version "0.13.0" and a build number at least as high
 as that shown in the example version check above.
 
 It is likely that you'll download a build which is _greater_ than
@@ -88,7 +88,8 @@ that if you update one, you may need to also update the other.
 
 ### Version Changes
 
-Version-0.12.0-dev.3518
+Version-0.13.0-dev.339
+* *2024-05-29* zig 0.13.0-dev.339 - rework std.Progress - see [#20059](https://github.com/ziglang/zig/pull/20059)
 * *2024-03-21* zig 0.12.0-dev.3518 - change to @fieldParentPtr - see [#19470](https://github.com/ziglang/zig/pull/19470)
 * *2024-03-21* zig 0.12.0-dev.3397 - rename std.os to std.posix - see [#5019](https://github.com/ziglang/zig/issues/5019)
 * *2024-03-14* zig 0.12.0-dev.3302 - changes in `std.fmt` - floating-point formatting implementation - see [#19229](https://github.com/ziglang/zig/pull/19229)

build.zig

@@ -15,7 +15,7 @@ const print = std.debug.print;
 //     1) Getting Started
 //     2) Version Changes
 comptime {
-    const required_zig = "0.12.0-dev.3518";
+    const required_zig = "0.13.0-dev.339";
     const current_zig = builtin.zig_version;
     const min_zig = std.SemanticVersion.parse(required_zig) catch unreachable;
     if (current_zig.order(min_zig) == .lt) {
@@ -244,7 +244,7 @@ const ZiglingStep = struct {
         return self;
     }
 
-    fn make(step: *Step, prog_node: *std.Progress.Node) !void {
+    fn make(step: *Step, prog_node: std.Progress.Node) !void {
         // NOTE: Using exit code 2 will prevent the Zig compiler to print the message:
         // "error: the following build command failed with exit code 1:..."
         const self: *ZiglingStep = @alignCast(@fieldParentPtr("step", step));
@@ -279,7 +279,7 @@ const ZiglingStep = struct {
         self.printErrors();
     }
 
-    fn run(self: *ZiglingStep, exe_path: []const u8, _: *std.Progress.Node) !void {
+    fn run(self: *ZiglingStep, exe_path: []const u8, _: std.Progress.Node) !void {
         resetLine();
         print("Checking: {s}\n", .{self.exercise.main_file});
 
@@ -375,7 +375,7 @@ const ZiglingStep = struct {
         print("{s}PASSED{s}\n\n", .{ green_text, reset_text });
     }
 
-    fn compile(self: *ZiglingStep, prog_node: *std.Progress.Node) !?[]const u8 {
+    fn compile(self: *ZiglingStep, prog_node: std.Progress.Node) !?[]const u8 {
         print("Compiling: {s}\n", .{self.exercise.main_file});
 
         const b = self.step.owner;
@@ -494,7 +494,7 @@ const PrintStep = struct {
         return self;
     }
 
-    fn make(step: *Step, _: *std.Progress.Node) !void {
+    fn make(step: *Step, _: std.Progress.Node) !void {
         const self: *PrintStep = @alignCast(@fieldParentPtr("step", step));
         print("{s}", .{self.message});
     }
@@ -1128,7 +1128,7 @@ const exercises = [_]Exercise{
         .main_file = "107_files2.zig",
         .output =
         \\AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
-        \\Successfully Read 18 byte: It's zigling time!
+        \\Successfully Read 18 bytes: It's zigling time!
         ,
     },
     .{

exercises/046_optionals2.zig

@@ -51,8 +51,6 @@ fn visitElephants(first_elephant: *Elephant) void {
         // We should stop once we encounter a tail that
         // does NOT point to another element. What can
         // we put here to make that happen?
-        if (e.tail == null) ???;
+        e = e.tail ???
-
-        e = e.tail.?;
     }
 }

exercises/047_methods.zig

@@ -40,7 +40,7 @@
 // Okay, you're armed.
 //
 // Now, please zap the alien structs until they're all gone or
-// Earth will be doomed!
+// the Earth will be doomed!
 //
 const std = @import("std");
 

exercises/094_c_math.zig

@@ -13,7 +13,7 @@
 // How could we do that? A good method is to use the modulo function.
 // But if we write "765.2 % 360", it only works with float values
 // that are known at compile time.
-// In Zig, we would use %mod(a, b) instead.
+// In Zig, we would use @mod(a, b) instead.
 //
 // Let us now assume that we cannot do this in Zig, but only with
 // a C function from the standard library. In the library "math",

exercises/096_memory_allocation.zig

@@ -30,9 +30,9 @@
 //         std.debug.print("slice_ptr={*}\n", .{slice_ptr});
 //     }
 
-// Instead of a simple integer or a constant sized slice, this
+// Instead of a simple integer or a slice with a constant size,
-// program requires a slice to be allocated that is the same size as
+// this program requires allocating a slice that is the same size
-// an input array.
+// as an input array.
 
 // Given a series of numbers, take the running average. In other
 // words, each item N should contain the average of the last N

exercises/097_bit_manipulation.zig

@@ -1,5 +1,5 @@
 //
-// Bit manipulations is a very powerful tool just also from Zig.
+// Bit manipulation is a very powerful tool, also from Zig.
 // Since the dawn of the computer age, numerous algorithms have been
 // developed that solve tasks solely by moving, setting, or logically
 // combining bits.
@@ -8,10 +8,10 @@
 // functions where possible. And it is often possible with calculations
 // based on integers.
 //
-// Often it is not easy to understand at first glance what exactly these
+// At first glance, it is often not easy to understand what exactly these
 // algorithms do when only "numbers" in memory areas change outwardly.
-// But it must never be forgotten that the numbers only represent the
+// However, it should never be forgotten that the numbers only represent
-// interpretation of the bit sequences.
+// the interpretation of the bit sequences.
 //
 // Quasi the reversed case we have otherwise, namely that we represent
 // numbers in bit sequences.
@@ -21,7 +21,7 @@
 // Zig provides all the necessary functions to change the bits inside
 // a variable. It is distinguished whether the bit change leads to an
 // overflow or not. The details are in the Zig documentation in section
-// 10.1 "Table of Operators".
+// "Table of Operators".
 //
 // Here are some examples of how the bits of variables can be changed:
 //

exercises/098_bit_manipulation2.zig

@@ -1,5 +1,5 @@
 //
-// Another useful practice for bit manipulation is setting bits as flags.
+// Another useful application for bit manipulation is setting bits as flags.
 // This is especially useful when processing lists of something and storing
 // the states of the entries, e.g. a list of numbers and for each prime
 // number a flag is set.
@@ -19,9 +19,9 @@
 // For example, you could take an array of bool and set the value to 'true'
 // for each letter in the order of the alphabet (a=0; b=1; etc.) found in
 // the sentence. However, this is neither memory efficient nor particularly
-// fast. Instead we take a simpler way, very similar in principle, we define
+// fast. Instead we choose a simpler approach that is very similar in principle:
-// a variable with at least 26 bits (e.g. u32) and also set the bit for each
+// We define a variable with at least 26 bits (e.g. u32) and set the bit for
-// letter found at the corresponding position.
+// each letter that is found in the corresponding position.
 //
 // Zig provides functions for this in the standard library, but we prefer to
 // solve it without these extras, after all we want to learn something.
@@ -39,7 +39,7 @@ fn isPangram(str: []const u8) bool {
     // first we check if the string has at least 26 characters
     if (str.len < 26) return false;
 
-    // we uses a 32 bit variable of which we need 26 bits
+    // we use a 32 bit variable of which we need 26 bits
     var bits: u32 = 0;
 
     // loop about all characters in the string

exercises/099_formatting.zig

@@ -19,10 +19,10 @@
 //     https://github.com/ziglang/zig/blob/master/lib/std/fmt.zig#L29
 //
 // Zig already has a very nice selection of formatting options.
-// These can be used in different ways, but typically to convert
+// These can be used in different ways, but generally to convert
-// numerical values into various text representations. The
+// numerical values into various text representations. The results
-// results can be used for direct output to a terminal or stored
+// can be used for direct output to a terminal or stored for
-// for later use or written to a file. The latter is useful when
+// later use or written to a file. The latter is useful when
 // large amounts of data are to be processed by other programs.
 //
 // In Ziglings, we are concerned with the output to the console.
@@ -45,7 +45,7 @@
 // output. Escape sequences can also be written one after the
 // other, e.g. "\n\n" will cause two line feeds.
 //
-// By the way, the result of these escape sequences are passed
+// By the way, the result of these escape sequences is passed
 // directly to the terminal program. Other than translating them
 // into control codes, escape sequences have nothing to do with
 // Zig. Zig knows nothing about "line feeds" or "tabs" or
@@ -95,7 +95,7 @@
 //      ...
 //
 // Without string formatting, this would be a more challenging
-// assignment because the number of digits in the numbers vary
+// assignment because the number of digits in the numbers varies
 // from 1 to 3. But formatting can help us with that.
 //
 const std = @import("std");

exercises/104_threading.zig

@@ -4,8 +4,8 @@
 // one possibility, namely asynchronous processes, in Exercises 84-91.
 //
 // However, the computing power of the processor is only distributed to
-// the started tasks, which always reaches its limits when pure computing
+// the started and running tasks, which always reaches its limits when
-// power is called up.
+// pure computing power is called up.
 //
 // For example, in blockchains based on proof of work, the miners have
 // to find a nonce for a certain character string so that the first m bits

exercises/105_threading2.zig

@@ -1,6 +1,6 @@
 //
-// Now that we are familiar with the principles of multi threading, we
+// Now that we are familiar with the principles of multi-threading,
-// boldly venture into a practical example from mathematics.
+// let's boldly venture into a practical example from mathematics.
 // We will determine the circle number PI with sufficient accuracy.
 //
 // There are different methods for this, and some of them are several
@@ -104,4 +104,4 @@ fn thread_pi(pi: *f64, begin: u64, end: u64) !void {
 // to such an extent that seconds become minutes during execution.
 //
 // And you should remove the formatting restriction in "print",
-// otherwise you will not be able to see the additional diggits.
+// otherwise you will not be able to see the additional digits.

exercises/106_files.zig

@@ -50,20 +50,20 @@ pub fn main() !void {
     // we try to open the file `zigling.txt`,
     // and propagate the error up if there are any errors
     const file: std.fs.File = try output_dir.createFile("zigling.txt", .{});
-    // it is a good habit to close a file after you are done with
+    // it is a good habit to close a file after you are done with it
-    // so that other program can read it and prevent data corruption
+    // so that other programs can read it and prevent data corruption
     // but here we are not yet done writing to the file
-    // if only there are a keyword in zig that
+    // if only there were a keyword in zig that
-    // allow you "defer" code execute to the end of scope...
+    // allows you "defer" code execute to the end of scope...
     file.close();
 
-    // !you are not allow to switch this two lines to before file closing line!
+    // !you are not allowed to switch these two lines above the file closing line!
     const byte_written = try file.write("It's zigling time!");
     std.debug.print("Successfully wrote {d} bytes.\n", .{byte_written});
 }
 // to check if you actually write to the file, you can either,
 // 1. open the file on your text editor, or
-// 2. print the content of the file in the console with command
+// 2. print the content of the file in the console with the following command
 //    >> cat ./output/zigling.txt
 //
 //
@@ -89,4 +89,4 @@ pub fn main() !void {
 //   - go to documentation of the struct `std.fs.Dir` here
 //     https://ziglang.org/documentation/master/std/#std.fs.Dir
 //       - can you find a function for opening a file? how about deleting a file?
-//       - what kind of option can you uses with those function?
+//       - what kind of options can you use with those functions?

exercises/107_files2.zig

@@ -5,14 +5,14 @@
 //      with content `It's zigling time!`(18 byte total)
 //
 // Now there no point in writing to a file if we don't read from it am I right?
-// let's wrote a program to read the content of the file that we just created.
+// let's write a program to read the content of the file that we just created.
 //
-// I am assuming you've created the appropriate files for this to work.
+// I am assuming that you've created the appropriate files for this to work.
 //
 // Alright, bud, lean in close here's the game plan.
 //    - First, we open the {project_root}/output/ directory
 //    - Secondly, we open file `zigling.txt` in that directory
-//    - then, we initalize an array of character with all letter 'A', and print it
+//    - then, we initalize an array of characters with all letter 'A', and print it
 //    - After that, we read the content of the file to the array
 //    - Finally, we print out the read content
 
@@ -31,22 +31,22 @@ pub fn main() !void {
     defer file.close();
 
     // initalize an array of u8 with all letter 'A'.
-    // we need to pick a size of the array, 64 seems like a good number.
+    // we need to pick the size of the array, 64 seems like a good number.
     // fix the initalization below
     var content = ['A']*64;
     // this should print out : `AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA`
     std.debug.print("{s}\n", .{content});
 
-    // okay, seem like threat of violence is not the answer in this case
+    // okay, seems like a threat of violence is not the answer in this case
     // can you go here to find a way to read the content ?
     // https://ziglang.org/documentation/master/std/#std.fs.File
-    // hint: you might find two answer that are both vaild in this case
+    // hint: you might find two answers that are both vaild in this case
-    const byte_read = zig_read_the_file_or_i_will_fight_you(&content);
+    const bytes_read = zig_read_the_file_or_i_will_fight_you(&content);
 
     // Woah, too screamy, I know you're excited for zigling time but tone it down a bit
     // Can you print only what we read from the file ?
-    std.debug.print("Successfully Read {d} byte: {s}\n", .{
+    std.debug.print("Successfully Read {d} bytes: {s}\n", .{
-        byte_read,
+        bytes_read,
         content, // change this line only
     });
 }

patches/patches/046_optionals2.patch

@@ -1,5 +1,5 @@
---- exercises/046_optionals2.zig	2023-10-03 22:15:22.122241138 +0200
+--- exercises/046_optionals2.zig	2024-05-10 23:11:25.796632478 +0200
-+++ answers/046_optionals2.zig	2023-10-05 20:04:07.049433424 +0200
++++ answers/046_optionals2.zig	2024-05-10 23:10:16.115335668 +0200
 @@ -21,7 +21,7 @@
  
  const Elephant = struct {
@@ -9,12 +9,11 @@
      visited: bool = false,
  };
  
-@@ -51,7 +51,7 @@
+@@ -51,6 +51,6 @@
          // We should stop once we encounter a tail that
          // does NOT point to another element. What can
          // we put here to make that happen?
--        if (e.tail == null) ???;
+-        e = e.tail ???
-+        if (e.tail == null) break;
++        e = e.tail orelse break;
- 
-         e = e.tail.?;
      }
+ }

patches/patches/106_files.patch

@@ -1,5 +1,5 @@
---- exercises/106_files.zig	2024-03-27 16:52:05.660910200 +0800
+--- exercises/106_files.zig	2024-05-05 00:48:25.808548611 +0200
-+++ answers/106_files.zig	2024-03-27 16:52:09.649422200 +0800
++++ answers/106_files.zig	2024-05-05 01:00:40.742969819 +0200
 @@ -35,7 +35,7 @@
          // by doing nothing
          //
@@ -20,10 +20,10 @@
      // we try to open the file `zigling.txt`,
 @@ -55,7 +55,7 @@
      // but here we are not yet done writing to the file
-     // if only there are a keyword in zig that
+     // if only there were a keyword in zig that
-     // allow you "defer" code execute to the end of scope...
+     // allows you "defer" code execute to the end of scope...
 -    file.close();
 +    defer file.close();
  
-     // !you are not allow to switch this two lines to before file closing line!
+     // !you are not allowed to switch these two lines above the file closing line!
      const byte_written = try file.write("It's zigling time!");

patches/patches/107_files2.patch

@@ -1,8 +1,8 @@
---- exercises/107_files2.zig	2024-03-27 16:51:56.199719600 +0800
+--- exercises/107_files2.zig	2024-05-05 00:48:25.808548611 +0200
-+++ answers/107_files2.zig	2024-03-27 16:52:01.650935300 +0800
++++ answers/107_files2.zig	2024-05-05 01:14:03.866062288 +0200
 @@ -33,7 +33,7 @@
      // initalize an array of u8 with all letter 'A'.
-     // we need to pick a size of the array, 64 seems like a good number.
+     // we need to pick the size of the array, 64 seems like a good number.
      // fix the initalization below
 -    var content = ['A']*64;
 +    var content = [_]u8{'A'} ** 64;
@@ -12,15 +12,15 @@
 @@ -41,12 +41,12 @@
      // can you go here to find a way to read the content ?
      // https://ziglang.org/documentation/master/std/#std.fs.File
-     // hint: you might find two answer that are both vaild in this case
+     // hint: you might find two answers that are both vaild in this case
--    const byte_read = zig_read_the_file_or_i_will_fight_you(&content);
+-    const bytes_read = zig_read_the_file_or_i_will_fight_you(&content);
-+    const byte_read = try file.read(&content);
++    const bytes_read = try file.read(&content);
  
      // Woah, too screamy, I know you're excited for zigling time but tone it down a bit
      // Can you print only what we read from the file ?
-     std.debug.print("Successfully Read {d} byte: {s}\n", .{
+     std.debug.print("Successfully Read {d} bytes: {s}\n", .{
-         byte_read,
+         bytes_read,
 -        content, // change this line only
-+        content[0..byte_read], // change this line only
++        content[0..bytes_read], // change this line only
      });
  }

test/tests.zig

@@ -150,7 +150,7 @@ const CheckNamedStep = struct {
         return self;
     }
 
-    fn make(step: *Step, _: *std.Progress.Node) !void {
+    fn make(step: *Step, _: std.Progress.Node) !void {
         const b = step.owner;
         const self: *CheckNamedStep = @alignCast(@fieldParentPtr("step", step));
         const ex = self.exercise;
@@ -202,7 +202,7 @@ const CheckStep = struct {
         return self;
     }
 
-    fn make(step: *Step, _: *std.Progress.Node) !void {
+    fn make(step: *Step, _: std.Progress.Node) !void {
         const b = step.owner;
         const self: *CheckStep = @alignCast(@fieldParentPtr("step", step));
         const exercises = self.exercises;
@@ -325,7 +325,7 @@ const FailStep = struct {
         return self;
     }
 
-    fn make(step: *Step, _: *std.Progress.Node) !void {
+    fn make(step: *Step, _: std.Progress.Node) !void {
         const b = step.owner;
         const self: *FailStep = @alignCast(@fieldParentPtr("step", step));
 
@@ -368,7 +368,7 @@ const HealStep = struct {
         return self;
     }
 
-    fn make(step: *Step, _: *std.Progress.Node) !void {
+    fn make(step: *Step, _: std.Progress.Node) !void {
         const b = step.owner;
         const self: *HealStep = @alignCast(@fieldParentPtr("step", step));