sam_oneal/dial-reference
1
0
Fork 0
mirror of https://github.com/Netflix/dial-reference.git synced 2026-06-08 10:59:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace unsafe strcpy with strncpy.

Browse Source 
Valgrind is happy now.
This commit is contained in:
Chintan Parikh
2017-10-02 16:06:32 -07:00
parent 4b8f7637b1
commit e902089402
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/dial_data.c
View File

@@ -76,10 +76,10 @@ DIALData *retrieve_dial_data(char *app_name) {
char value[256]; char value[256];
while (fscanf(f, "%255s %255s\n", key, value) != EOF) { while (fscanf(f, "%255s %255s\n", key, value) != EOF) {
DIALData *newNode = (DIALData *) malloc(sizeof(DIALData)); DIALData *newNode = (DIALData *) malloc(sizeof(DIALData));
newNode->key = (char *) malloc(strlen(key)); newNode->key = (char *) calloc(1, strlen(key));
strcpy(newNode->key, key); strncpy(newNode->key, key, strlen(key));
newNode->value = (char *) malloc(strlen(value)); newNode->value = (char *) calloc(1, strlen(value));
strcpy(newNode->value, value); strncpy(newNode->value, value, strlen(value));
newNode->next = result; newNode->next = result;
result = newNode; result = newNode;
} }