ReceiverSelectorManager naming changes

This commit is contained in:
hensm
2019-04-12 10:59:57 +01:00
committed by Matt Hensman
parent 40d6b55332
commit 5dd91f3ee0
3 changed files with 20 additions and 15 deletions

View File

@@ -3,20 +3,25 @@
import { Receiver } from "../types";
export type ReceiverSelectorSelectedEvent = CustomEvent<Receiver>;
export type ReceiverSelectorErrorEvent = CustomEvent;
export type ReceiverSelectorCancelledEvent = CustomEvent;
export enum ReceiverSelectorCastType {
export enum ReceiverSelectorMediaType {
App
, Tab
, Screen
}
export interface ReceiverSelection {
receiver: Receiver;
castMethod: ReceiverSelectorMediaType;
}
export type ReceiverSelectorSelectedEvent = CustomEvent<ReceiverSelection>;
export type ReceiverSelectorErrorEvent = CustomEvent;
export type ReceiverSelectorCancelledEvent = CustomEvent;
export default interface ReceiverSelectorManager extends EventTarget {
open (
receivers: Receiver[]
, defaultCastType: ReceiverSelectorCastType): void;
open (receivers: Receiver[]
, defaultMediaType: ReceiverSelectorMediaType): void;
close (): void;
}

View File

@@ -1,7 +1,7 @@
"use strict";
import ReceiverSelectorManager, {
ReceiverSelectorCastType } from "../ReceiverSelectorManager";
ReceiverSelectorMediaType } from "../ReceiverSelectorManager";
import { Message, Receiver } from "../../types";
@@ -12,7 +12,7 @@ class NativeMacReceiverSelectorManager
public async open (
receivers: Receiver[]
, defaultCastType: ReceiverSelectorCastType): Promise<void> {
, defaultMediaType: ReceiverSelectorMediaType): Promise<void> {
console.info("STUB :: NativeMacReceiverSelectorManager.open");
}

View File

@@ -1,7 +1,7 @@
"use strict";
import ReceiverSelectorManager, {
ReceiverSelectorCastType } from "../ReceiverSelectorManager";
ReceiverSelectorMediaType } from "../ReceiverSelectorManager";
import { getWindowCenteredProps } from "../../lib/utils";
import { Message, Receiver } from "../../types";
@@ -16,7 +16,7 @@ class PopupReceiverSelectorManager
private messagePort: browser.runtime.Port;
private receivers: Receiver[];
private defaultCastType: ReceiverSelectorCastType;
private defaultMediaType: ReceiverSelectorMediaType;
private wasReceiverSelected: boolean = false;
@@ -55,7 +55,7 @@ class PopupReceiverSelectorManager
public async open (
receivers: Receiver[]
, defaultCastType: ReceiverSelectorCastType): Promise<void> {
, defaultMediaType: ReceiverSelectorMediaType): Promise<void> {
// If popup already exists, close it
if (this.windowId) {
@@ -63,7 +63,7 @@ class PopupReceiverSelectorManager
}
this.receivers = receivers;
this.defaultCastType = defaultCastType;
this.defaultMediaType = defaultMediaType;
// Current window to base centered position on
const openerWindow = await browser.windows.getCurrent();
@@ -126,7 +126,7 @@ class PopupReceiverSelectorManager
this.openerWindowId = null;
this.messagePort = null;
this.receivers = null;
this.defaultCastType = null;
this.defaultMediaType = null;
this.wasReceiverSelected = false;
}