sam_oneal/fx_cast
1
0
Fork 0
mirror of https://github.com/hensm/fx_cast.git synced 2026-06-12 02:29:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use private fields instead of underscore prefixes

Browse Source
This commit is contained in:
hensm
2021-04-25 01:34:23 +01:00
parent 0b2e4bdbbc
commit c1b6c6734e
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
ext/src/background/receiverSelector/NativeReceiverSelector.ts
View File

@@ -21,7 +21,8 @@ const _ = browser.i18n.getMessage;
export default class NativeReceiverSelector extends ReceiverSelector { export default class NativeReceiverSelector extends ReceiverSelector {
private bridgePort: (Port | null) = null; private bridgePort: (Port | null) = null;
private wasReceiverSelected: boolean = false; private wasReceiverSelected: boolean = false;
private _isOpen: boolean = false;
#isOpen = false;
constructor () { constructor () {
super(); super();
@@ -29,7 +30,7 @@ export default class NativeReceiverSelector extends ReceiverSelector {
} }
get isOpen () { get isOpen () {
return this._isOpen; return this.#isOpen;
} }
public async open ( public async open (
@@ -44,7 +45,7 @@ export default class NativeReceiverSelector extends ReceiverSelector {
this.bridgePort.onDisconnect.addListener(() => { this.bridgePort.onDisconnect.addListener(() => {
this.bridgePort = null; this.bridgePort = null;
this.wasReceiverSelected = false; this.wasReceiverSelected = false;
this._isOpen = false; this.#isOpen = false;
}); });
@@ -82,7 +83,7 @@ export default class NativeReceiverSelector extends ReceiverSelector {
}) })
}); });
this._isOpen = true; this.#isOpen = true;
} }
public update (): void { public update (): void {
@@ -96,7 +97,7 @@ export default class NativeReceiverSelector extends ReceiverSelector {
}); });
} }
this._isOpen = false; this.#isOpen = false;
} }
private async onBridgePortMessage (message: Message) { private async onBridgePortMessage (message: Message) {
@@ -129,7 +130,7 @@ export default class NativeReceiverSelector extends ReceiverSelector {
this.bridgePort = null; this.bridgePort = null;
this.wasReceiverSelected = false; this.wasReceiverSelected = false;
this._isOpen = false; this.#isOpen = false;
break; break;
} }

9
ext/src/background/receiverSelector/PopupReceiverSelector.ts
View File

@@ -25,10 +25,9 @@ export default class PopupReceiverSelector extends ReceiverSelector {
private availableMediaTypes?: ReceiverSelectorMediaType; private availableMediaTypes?: ReceiverSelectorMediaType;
private wasReceiverSelected: boolean = false; private wasReceiverSelected: boolean = false;
private _isOpen: boolean = false;
private requestedAppId?: string; private requestedAppId?: string;
#isOpen = false;
constructor () { constructor () {
super(); super();
@@ -49,7 +48,7 @@ export default class PopupReceiverSelector extends ReceiverSelector {
} }
get isOpen () { get isOpen () {
return this._isOpen; return this.#isOpen;
} }
public async open ( public async open (
@@ -96,7 +95,7 @@ export default class PopupReceiverSelector extends ReceiverSelector {
throw logger.error("Failed to create receiver selector popup."); throw logger.error("Failed to create receiver selector popup.");
} }
this._isOpen = true; this.#isOpen = true;
this.windowId = popup.id; this.windowId = popup.id;
// Size/position not set correctly on creation (bug?) // Size/position not set correctly on creation (bug?)
@@ -130,7 +129,7 @@ export default class PopupReceiverSelector extends ReceiverSelector {
await browser.windows.remove(this.windowId); await browser.windows.remove(this.windowId);
} }
this._isOpen = false; this.#isOpen = false;
this.requestedAppId = undefined; this.requestedAppId = undefined;
if (this.messagePort && !this.messagePortDisconnected) { if (this.messagePort && !this.messagePortDisconnected) {