Fix unused parameters

2026-06-08 08:39:59 +00:00 · 2019-08-16 21:09:35 +01:00
parent e2eca07876
commit 14d3b2c833
21 changed files with 95 additions and 103 deletions
--- a/app/src/bridge/Media.ts
+++ b/app/src/bridge/Media.ts
@@ -11,8 +11,8 @@ import { Message
 const MEDIA_NAMESPACE = "urn:x-cast:com.google.cast.media";

 export interface UpdateMessageData {
-    _volumeLevel: number;
-    _volumeMuted: boolean;
+    _volumeLevel?: number;
+    _volumeMuted?: boolean;
    _lastCurrentTime: number;
    currentTime: number;
    customData?: any;
@@ -28,9 +28,7 @@ export default class Media {
    private channel: Channel;

    constructor (
-            sessionId: number
-          , mediaSessionId: number
-          , private referenceId: string
+            private referenceId: string
          , private session: Session
          , private sendMessageCallback: SendMessageCallback) {

@@ -43,7 +41,7 @@ export default class Media {

                const status = data.status[0];

-                const messageData = {
+                const messageData: UpdateMessageData = {
                    _lastCurrentTime: Date.now() / 1000

                  , currentTime: status.currentTime
@@ -51,7 +49,7 @@ export default class Media {
                  , playbackRate: status.playbackRate
                  , playerState: status.playerState
                  , repeatMode: status.repeatMode
-                } as UpdateMessageData;
+                };

                if (status.volume) {
                    messageData._volumeLevel = status.volume.level;
--- a/app/src/bridge/index.ts
+++ b/app/src/bridge/index.ts
@@ -100,9 +100,7 @@ async function handleMessage (message: Message) {
                if (parentSession) {
                    // Create Media
                    existingMedia.set(mediaId, new Media(
-                            message.data.sessionId
-                          , message.data.mediaSessionId
-                          , mediaId
+                            mediaId
                          , parentSession
                          , sendMessage));
                }
@@ -271,7 +269,7 @@ function handleMediaServerMessage (message: Message) {
            mediaServer.on("close", () => {
                sendMessage("mediaCast:/mediaServer/stopped");
            });
-            mediaServer.on("error", (a) => {
+            mediaServer.on("error", () => {
                sendMessage("mediaCast:/mediaServer/error");
            });

--- a/app/src/transforms.ts
+++ b/app/src/transforms.ts
@@ -20,7 +20,7 @@ export class ResponseTransform extends Transform {

    public _transform (
            chunk: Message
-          , encoding: string
+          , _encoding: string
            // tslint:disable-next-line:ban-types
          , callback: Function) {

@@ -53,7 +53,7 @@ export class DecodeTransform extends Transform {

    public _transform (
            chunk: any
-          , encoding: string
+          , _encoding: string
            // tslint:disable-next-line:ban-types
          , callback: Function) {

@@ -113,7 +113,7 @@ export class EncodeTransform extends Transform {

    public _transform (
            chunk: any
-          , encoding: string
+          , _encoding: string
            // tslint:disable-next-line:ban-types
          , callback: Function) {

--- a/common/tsconfig.json
+++ b/common/tsconfig.json
@@ -4,6 +4,7 @@
      , "module": "commonjs"
      , "noImplicitAny": true
      , "noUnusedLocals": true
+      , "noUnusedParameters": true
      , "removeComments": true
      , "resolveJsonModule": true
      , "target": "es6"
--- a/ext/src/background/receiverSelector/NativeReceiverSelector.ts
+++ b/ext/src/background/receiverSelector/NativeReceiverSelector.ts
@@ -21,11 +21,6 @@ interface NativeReceiverSelectorSelectedMessage extends Message {
    data: ReceiverSelection;
 }

-interface NativeReceiverSelectorCloseMessage extends Message {
-    subject: "main:/receiverSelector/error";
-    data: string;
-}
-
 interface NativeReceiverSelectorErrorMessage extends Message {
    subject: "main:/receiverSelector/error";
    data: string;
@@ -65,8 +60,7 @@ export default class NativeReceiverSelector
                    break;
                }
                case "main:/receiverSelector/close": {
-                    this.onBridgePortMessageClose(
-                            message as NativeReceiverSelectorCloseMessage);
+                    this.onBridgePortMessageClose();
                    break;
                }
            }
@@ -140,12 +134,13 @@ export default class NativeReceiverSelector
    private async onBridgePortMessageError (
            message: NativeReceiverSelectorErrorMessage) {

+        console.error("fx_cast (Debug): Native receiver selector error"
+              , message.data);
+
        this.dispatchEvent(new CustomEvent("error"));
    }

-    private async onBridgePortMessageClose (
-            message: NativeReceiverSelectorCloseMessage) {
-
+    private async onBridgePortMessageClose () {
        if (!this.wasReceiverSelected) {
            this.dispatchEvent(new CustomEvent("cancelled"));
        }
--- a/ext/src/background/receiverSelector/ReceiverSelector.ts
+++ b/ext/src/background/receiverSelector/ReceiverSelector.ts
@@ -20,7 +20,7 @@ export interface ReceiverSelection {

 export interface ReceiverSelectorEvents {
    "selected": ReceiverSelection;
-    "error": void;
+    "error": string;
    "cancelled": void;
 }

--- a/ext/src/background/receiverSelector/ReceiverSelectorManager.ts
+++ b/ext/src/background/receiverSelector/ReceiverSelectorManager.ts
@@ -72,12 +72,12 @@ async function getSelection (
            resolve(ev.detail);
        });

-        sharedSelector.addEventListener("cancelled", ev => {
+        sharedSelector.addEventListener("cancelled", () => {
            console.info("fx_cast (Debug): Cancelled receiver selection");
            resolve(null);
        });

-        sharedSelector.addEventListener("error", ev => {
+        sharedSelector.addEventListener("error", () => {
            console.error("fx_cast (Debug): Failed to select receiver");
            reject();
        });
--- a/ext/src/lib/nativeMessaging.ts
+++ b/ext/src/lib/nativeMessaging.ts
@@ -100,7 +100,7 @@ function connectNative (application: string) {

            socket = new WebSocket(WEBSOCKET_DAEMON_URL);

-            socket.addEventListener("open", ev => {
+            socket.addEventListener("open", () => {
                // Send all messages in queue
                while (messageQueue.length) {
                    const message = messageQueue.pop();
--- a/ext/src/lib/userAgents.ts
+++ b/ext/src/lib/userAgents.ts
@@ -11,7 +11,7 @@ const UA_CHROME_LEGACY = "AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.288
 const UA_SAFARI = "AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Safari/605.1.15";


-function getPlatformComponent (platform: string) {
+function getPlatformComponent (platform: string): string {
    switch (platform) {
        case "mac": return PLATFORM_MAC; break;
        case "win": return PLATFORM_WIN; break;
@@ -31,6 +31,6 @@ export function getChromeUserAgent (
    return `${UA_PREFIX} (${platformComponent}) ${browserComponent}`;
 }

-export function getSafariUserAgent (platform: string): string {
+export function getSafariUserAgent (): string {
    return `${UA_PREFIX} (${PLATFORM_MAC}) ${UA_SAFARI}`;
 }
--- a/ext/src/senders/mediaCast.ts
+++ b/ext/src/senders/mediaCast.ts
@@ -17,7 +17,7 @@ function getLocalAddress () {
                resolve(ev.candidate.candidate.split(" ")[4]);
            }
        });
-        pc.addEventListener("error", ev => {
+        pc.addEventListener("error", () => {
            reject();
        });
    });
@@ -109,7 +109,7 @@ function getSession (opts: InitOptions): Promise<cast.Session> {
 }

 function getMedia (opts: InitOptions): Promise<cast.media.Media> {
-    return new Promise(async (resolve, reject) => {
+    return new Promise(async resolve => {
        let mediaUrlObject = new URL(opts.mediaUrl);
        const mediaTitle = mediaUrlObject.pathname;

--- a/ext/src/senders/mirroringCast.ts
+++ b/ext/src/senders/mirroringCast.ts
@@ -50,7 +50,7 @@ async function onRequestSessionSuccess (newSession: cast.Session) {

    session = newSession;
    session.addMessageListener(FX_CAST_RECEIVER_APP_NAMESPACE
-          , async (namespace, message) => {
+          , async (_namespace, message) => {

        const { subject, data } = JSON.parse(message);

--- a/ext/src/shim/cast/classes/Session.ts
+++ b/ext/src/shim/cast/classes/Session.ts
@@ -249,7 +249,7 @@ export default class Session {
    }


-    public addMediaListener (listener: MediaListener) {
+    public addMediaListener (_mediaListener: MediaListener) {
        console.info("STUB :: Session#addMediaListener");
    }

@@ -313,7 +313,7 @@ export default class Session {

        this.addMessageListener(
                "urn:x-cast:com.google.cast.media"
-              , (namespace, data) => {
+              , (_namespace, data) => {

            if (hasResponded) {
                return;
@@ -346,14 +346,14 @@ export default class Session {
    }

    public queueLoad (
-            queueLoadRequest: QueueLoadRequest
-          , successCallback: LoadSuccessCallback
-          , errorCallback: ErrorCallback): void {
+            _queueLoadRequest: QueueLoadRequest
+          , _successCallback: LoadSuccessCallback
+          , _errorCallback: ErrorCallback): void {

        console.info("STUB :: Session#queueLoad");
    }

-    public removeMediaListener (listener: MediaListener): void {
+    public removeMediaListener (_mediaListener: MediaListener): void {
        console.info("STUB :: Session#removeMediaListener");
    }

@@ -365,7 +365,7 @@ export default class Session {
    }

    public removeUpdateListener (
-            namespace: string
+            _namespace: string
          , listener: UpdateListener): void {

        _updateListeners.get(this).delete(listener);
--- a/ext/src/shim/cast/index.ts
+++ b/ext/src/shim/cast/index.ts
@@ -117,7 +117,7 @@ export function logMessage (message: string): void {
    console.log("CAST MSG:", message);
 }

-export function precache (data: string): void {
+export function precache (_data: string): void {
    console.info("STUB :: cast.precache");
 }

@@ -130,7 +130,7 @@ export function removeReceiverActionListener (
 export function requestSession (
        successCallback?: RequestSessionSuccessCallback
      , errorCallback?: ErrorCallback
-      , sessionRequest: SessionRequest = apiConfig.sessionRequest): void {
+      , _sessionRequest: SessionRequest = apiConfig.sessionRequest): void {

    console.info("fx_cast (Debug): cast.requestSession");

@@ -247,23 +247,23 @@ export function _requestSession (
    }
 }

-export function requestSessionById (sessionId: string): void {
+export function requestSessionById (_sessionId: string): void {
    console.info("STUB :: cast.requestSessionById");
 }

 export function setCustomReceivers (
-        receivers: Receiver_[]
-      , successCallback?: SuccessCallback
-      , errorCallback?: ErrorCallback): void {
+        _receivers: Receiver_[]
+      , _successCallback?: SuccessCallback
+      , _errorCallback?: ErrorCallback): void {

    console.info("STUB :: cast.setCustomReceivers");
 }

-export function setPageContext (win: Window): void {
+export function setPageContext (_win: Window): void {
    console.info("STUB :: cast.setPageContext");
 }

-export function setReceiverDisplayStatus (sessionId: string): void {
+export function setReceiverDisplayStatus (_sessionId: string): void {
    console.info("STUB :: cast.setReceiverDisplayStatus");
 }

--- a/ext/src/shim/cast/media/classes/Media.ts
+++ b/ext/src/shim/cast/media/classes/Media.ts
@@ -141,9 +141,9 @@ export default class Media {
    }

    public editTracksInfo (
-            editTracksInfoRequest: EditTracksInfoRequest
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _editTracksInfoRequest: EditTracksInfoRequest
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {

        console.info("STUB :: Media#editTracksInfo");
    }
@@ -158,7 +158,7 @@ export default class Media {
    }

    public getStatus (
-            getStatusRequest?: GetStatusRequest
+            _getStatusRequest?: GetStatusRequest
          , successCallback?: SuccessCallback
          , errorCallback?: ErrorCallback): void {

@@ -167,7 +167,7 @@ export default class Media {
    }

    public pause (
-            pauseRequest: PauseRequest
+            _pauseRequest: PauseRequest
          , successCallback?: SuccessCallback
          , errorCallback?: ErrorCallback): void {

@@ -176,7 +176,7 @@ export default class Media {
    }

    public play (
-            playRequest?: PlayRequest
+            _playRequest?: PlayRequest
          , successCallback?: SuccessCallback
          , errorCallback?: ErrorCallback): void {

@@ -185,71 +185,71 @@ export default class Media {
    }

    public queueAppendItem (
-            item: QueueItem
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _item: QueueItem
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueAppendItem");
    }

    public queueInsertItems (
-            queueInsertItemsRequest: QueueInsertItemsRequest
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _queueInsertItemsRequest: QueueInsertItemsRequest
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueInsertItems");
    }

    public queueJumpToItem (
-            itemId: number
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _itemId: number
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueJumpToItem");
    }

    public queueMoveItemToNewIndex (
-            itemId: number
-          , newIndex: number
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _itemId: number
+          , _newIndex: number
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueMoveItemToNewIndex");
    }

    public queueNext (
-            successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueNext");
    }

    public queuePrev (
-            successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queuePrev");
    }

    public queueRemoveItem (
-            itemId: number
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _itemId: number
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueRemoveItem");
    }

    public queueReorderItems (
-            queueReorderItemsRequest: QueueReorderItemsRequest
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _queueReorderItemsRequest: QueueReorderItemsRequest
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueReorderItems");
    }

    public queueSetRepeatMode (
-            repeatMode: string
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _repeatMode: string
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueSetRepeatMode");
    }

    public queueUpdateItems (
-            queueUpdateItemsRequest: QueueUpdateItemsRequest
-          , successCallback?: SuccessCallback
-          , errorCallback?: ErrorCallback): void {
+            _queueUpdateItemsRequest: QueueUpdateItemsRequest
+          , _successCallback?: SuccessCallback
+          , _errorCallback?: ErrorCallback): void {
        console.info("STUB :: Media#queueUpdateItems");
    }

@@ -280,7 +280,7 @@ export default class Media {
    }

    public stop (
-            stopRequest: StopRequest
+            _stopRequest: StopRequest
          , successCallback?: SuccessCallback
          , errorCallback?: ErrorCallback): void {

@@ -289,7 +289,7 @@ export default class Media {
        }, successCallback, errorCallback);
    }

-    public supportsCommand (command: string): boolean {
+    public supportsCommand (_command: string): boolean {
        console.info("STUB :: Media#supportsCommand");
        return true;
    }
--- a/ext/src/shim/framework/GoogleCastLauncher.ts
+++ b/ext/src/shim/framework/GoogleCastLauncher.ts
@@ -71,7 +71,7 @@ export default class GoogleCastLauncher extends HTMLElement {
        shadow.append(icon, style);


-        this.addEventListener("click", ev => {
+        this.addEventListener("click", () => {
            console.info("<google-cast-launcher> onClick");
        });
    }
--- a/ext/src/shim/framework/classes/CastContext.ts
+++ b/ext/src/shim/framework/classes/CastContext.ts
@@ -5,7 +5,7 @@ import CastSession from "./CastSession";


 export default class CastContext extends EventTarget {
-    public endCurrentSession (stopCasting: boolean): void {
+    public endCurrentSession (_stopCasting: boolean): void {
        console.info("STUB :: CastContext#endCurrentSession");
    }

@@ -29,7 +29,7 @@ export default class CastContext extends EventTarget {
        console.info("STUB :: CastContext#requestSession");
    }

-    public setOptions (options: CastOptions): void {
+    public setOptions (_options: CastOptions): void {
        console.info("STUB :: CastContext#setOptions");
    }
 }
--- a/ext/src/shim/framework/classes/CastSession.ts
+++ b/ext/src/shim/framework/classes/CastSession.ts
@@ -9,19 +9,19 @@ type MessageListener = (namespace: string, message: string) => void;


 export default class CastSession extends EventTarget {
-    constructor (sessionObj: cast.Session, state: string) {
+    constructor (_sessionObj: cast.Session, _state: string) {
        super();
        console.info("STUB :: CastSession#constructor");
    }

    public addMessageListener (
-            namespace: string
-          , listener: MessageListener): void {
+            _namespace: string
+          , _listener: MessageListener): void {

        console.info("STUB :: CastSession#addMessageListener");
    }

-    public endSession (stopCasting: boolean): void {
+    public endSession (_stopCasting: boolean): void {
        console.info("STUB :: CastSession#endSession");
    }

@@ -76,32 +76,32 @@ export default class CastSession extends EventTarget {
    }

    // @ts-ignore
-    public loadMedia (loadRequest: cast.media.LoadRequest): Promise<string> {
+    public loadMedia (_loadRequest: cast.media.LoadRequest): Promise<string> {
        console.info("STUB :: CastSession#loadMedia");
    }

    public removeMessageListener (
-            namespace: string
-          , listener: MessageListener): void {
+            _namespace: string
+          , _listener: MessageListener): void {

        console.info("STUB :: CastSession#removeMessageListener");
    }

    public sendMessage (
-            namespace: string
+            _namespace: string
            // @ts-ignore
-          , data: any): Promise<string> {
+          , _data: any): Promise<string> {

        console.info("STUB :: CastSession#sendMessage");
    }

    // @ts-ignore
-    public setMute (isMute: boolean): Promise<string> {
+    public setMute (_isMute: boolean): Promise<string> {
        console.info("STUB :: CastSession#setMute");
    }

    // @ts-ignore
-    public setVolume (volume: number): Promise<string> {
+    public setVolume (_volume: number): Promise<string> {
        console.info("STUB :: CastSession#setVolume");
    }
 }
--- a/ext/src/shim/framework/classes/RemotePlayerController.ts
+++ b/ext/src/shim/framework/classes/RemotePlayerController.ts
@@ -4,7 +4,7 @@ import RemotePlayer from "./RemotePlayer";


 export default class RemotePlayerController extends EventTarget {
-    constructor (player: RemotePlayer) {
+    constructor (_player: RemotePlayer) {
        super();
        console.info("STUB :: RemotePlayerController#constructor");
    }
--- a/ext/src/shim/framework/index.ts
+++ b/ext/src/shim/framework/index.ts
@@ -54,7 +54,7 @@ export default {

  , VERSION: "1.0.07"

-  , setLoggerLevel (level: number) {
+  , setLoggerLevel (_level: number) {
        console.info("STUB :: cast.framework.setLoggerLevel");
    }
 };
--- a/ext/src/shim/index.ts
+++ b/ext/src/shim/index.ts
@@ -52,7 +52,7 @@ if (document.currentScript) {
        isFramework = true;

        const script = loadScript(CAST_FRAMEWORK_SCRIPT_URL);
-        script.addEventListener("load", ev => {
+        script.addEventListener("load", () => {
            callPageReadyFunction();
        });

--- a/ext/src/ui/options/EditableList.tsx
+++ b/ext/src/ui/options/EditableList.tsx
@@ -175,7 +175,7 @@ export default class EditableList extends Component<
        });
    }

-    private handleNewItemEdit (item: string, newItem: string) {
+    private handleNewItemEdit (_item: string, newItem: string) {
        this.setState({
            addingNewItem: false
        }, () => {